From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Vignesh R <vigneshr@ti.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v3 3/3] Input: ti_am335x_tsc - Prevent system suspend when TSC is in use
Date: Wed, 30 May 2018 14:44:39 -0700 [thread overview]
Message-ID: <20180530214439.GC203327@dtor-ws> (raw)
In-Reply-To: <20180424062741.7891-4-vigneshr@ti.com>
On Tue, Apr 24, 2018 at 11:57:41AM +0530, Vignesh R wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
>
> Prevent system suspend while user has finger on touch screen,
> because TSC is wakeup source and suspending device while in use will
> result in failure to disable the module.
> This patch uses pm_stay_awake() and pm_relax() APIs to prevent and
> resume system suspend as required.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
Applied, thank you.
> ---
>
> v3: No change
>
> drivers/input/touchscreen/ti_am335x_tsc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
> index a548b0dbe320..ae6fc9099636 100644
> --- a/drivers/input/touchscreen/ti_am335x_tsc.c
> +++ b/drivers/input/touchscreen/ti_am335x_tsc.c
> @@ -277,6 +277,7 @@ static irqreturn_t titsc_irq(int irq, void *dev)
> if (status & IRQENB_HW_PEN) {
> ts_dev->pen_down = true;
> irqclr |= IRQENB_HW_PEN;
> + pm_stay_awake(ts_dev->mfd_tscadc->dev);
> }
>
> if (status & IRQENB_PENUP) {
> @@ -286,6 +287,7 @@ static irqreturn_t titsc_irq(int irq, void *dev)
> input_report_key(input_dev, BTN_TOUCH, 0);
> input_report_abs(input_dev, ABS_PRESSURE, 0);
> input_sync(input_dev);
> + pm_relax(ts_dev->mfd_tscadc->dev);
> } else {
> ts_dev->pen_down = true;
> }
> @@ -524,6 +526,7 @@ static int __maybe_unused titsc_resume(struct device *dev)
> titsc_writel(ts_dev, REG_IRQWAKEUP,
> 0x00);
> titsc_writel(ts_dev, REG_IRQCLR, IRQENB_HW_PEN);
> + pm_relax(ts_dev->mfd_tscadc->dev);
> }
> titsc_step_config(ts_dev);
> titsc_writel(ts_dev, REG_FIFO0THR,
> --
> 2.17.0
>
--
Dmitry
next prev parent reply other threads:[~2018-05-30 21:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 6:27 [PATCH v3 0/3] ti_am335x_tsc: Fix suspend/resume Vignesh R
2018-04-24 6:27 ` [PATCH v3 1/3] Input: ti_am335x_tsc - Mark IRQ as wakeup capable Vignesh R
2018-05-30 21:47 ` Dmitry Torokhov
2018-04-24 6:27 ` [PATCH v3 2/3] Input: ti_am335x_tsc - Ack pending IRQs at probe and before suspend Vignesh R
2018-05-30 21:44 ` Dmitry Torokhov
2018-04-24 6:27 ` [PATCH v3 3/3] Input: ti_am335x_tsc - Prevent system suspend when TSC is in use Vignesh R
2018-05-30 21:44 ` Dmitry Torokhov [this message]
2018-05-14 15:04 ` [PATCH v3 0/3] ti_am335x_tsc: Fix suspend/resume Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180530214439.GC203327@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).