From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2 5/8] Input: cros_ec_keyb - Switch to SPDX identifier. Date: Tue, 5 Jun 2018 11:29:19 -0700 Message-ID: <20180605182919.GF202428@dtor-ws> References: <20180605175429.9072-1-enric.balletbo@collabora.com> <20180605175429.9072-6-enric.balletbo@collabora.com> <7085d0bb-557c-0796-d3ae-756e000a7950@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Fabio Estevam Cc: Enric Balletbo i Serra , linux-kernel , Gwendal Grignou , kernel@collabora.com, linux-input@vger.kernel.org List-Id: linux-input@vger.kernel.org On Tue, Jun 05, 2018 at 03:16:40PM -0300, Fabio Estevam wrote: > Hi Enric, > > On Tue, Jun 5, 2018 at 3:14 PM, Enric Balletbo i Serra > wrote: > > > Right, but the module license is set to GPL which means GNU Public License v2 or > > later, see [1]. So, there is a mismatch. In such cases I assumed GPL-2.0+ as the > > default. These mismatches are common so I think that should be fine for the > > authors, if someone is disagree just let me know and I will change. > > Ok, but I think you should add this explanation in the commit log to > make it clearer. If there is a conflict between the license notice and MODULE_LICENSE() we should go by the license notice. The license note is usually approved by companies, whereas MIODULE_LICENSE()s get moved, adjusted, etc. For ChromeOS kernel changes license notice is GPL v2 as documented at: https://www.chromium.org/chromium-os/how-tos-and-troubleshooting/kernel-faq section "Which copyright header should I use?" Thanks. -- Dmitry