linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Jiri Kosina <jikos@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mario.Limonciello@dell.com,
	Peter Hutterer <peter.hutterer@who-t.net>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH v2 02/13] input: add MT_TOOL_DIAL
Date: Thu,  7 Jun 2018 09:54:37 +0200	[thread overview]
Message-ID: <20180607075448.5706-3-benjamin.tissoires@redhat.com> (raw)
In-Reply-To: <20180607075448.5706-1-benjamin.tissoires@redhat.com>

A dial is a tool you place on a multitouch surface which reports its
orientation or a relative angle of rotation when rotating its knob.

Some examples are the Dell Totem (on the Canvas 27"), the Microsoft Dial,
or the Griffin Powermate, though the later can't be put on a touch surface.

We give some extra space to account for other types of fingers if we need
(MT_TOOL_THUMB)

Slightly change the documentation to not make it mandatory to update each
MT_TOOL we add.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

---

new in v2 (extracted from previous series in its own patch)
---
 Documentation/input/multi-touch-protocol.rst | 12 ++++++------
 include/uapi/linux/input-event-codes.h       |  3 ++-
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/Documentation/input/multi-touch-protocol.rst b/Documentation/input/multi-touch-protocol.rst
index b51751a0cd5d..6be70342e709 100644
--- a/Documentation/input/multi-touch-protocol.rst
+++ b/Documentation/input/multi-touch-protocol.rst
@@ -310,12 +310,12 @@ ABS_MT_TOOL_Y
 ABS_MT_TOOL_TYPE
     The type of approaching tool. A lot of kernel drivers cannot distinguish
     between different tool types, such as a finger or a pen. In such cases, the
-    event should be omitted. The protocol currently supports MT_TOOL_FINGER,
-    MT_TOOL_PEN, and MT_TOOL_PALM [#f2]_. For type B devices, this event is
-    handled by input core; drivers should instead use
-    input_mt_report_slot_state(). A contact's ABS_MT_TOOL_TYPE may change over
-    time while still touching the device, because the firmware may not be able
-    to determine which tool is being used when it first appears.
+    event should be omitted. The protocol currently mainly supports
+    MT_TOOL_FINGER, MT_TOOL_PEN, and MT_TOOL_PALM [#f2]_.
+    For type B devices, this event is handled by input core; drivers should
+    instead use input_mt_report_slot_state(). A contact's ABS_MT_TOOL_TYPE may
+    change over time while still touching the device, because the firmware may
+    not be able to determine which tool is being used when it first appears.
 
 ABS_MT_BLOB_ID
     The BLOB_ID groups several packets together into one arbitrarily shaped
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index e8841cdb1ebd..a8d55f3909d3 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -854,6 +854,7 @@
 #define MT_TOOL_FINGER		0
 #define MT_TOOL_PEN		1
 #define MT_TOOL_PALM		2
-#define MT_TOOL_MAX		2
+#define MT_TOOL_DIAL		10
+#define MT_TOOL_MAX		10
 
 #endif
-- 
2.14.3

  parent reply	other threads:[~2018-06-07  7:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07  7:54 [PATCH v2 00/13] Hid multitouch rewrite, support os system multi-axis devices, take 2 Benjamin Tissoires
2018-06-07  7:54 ` [PATCH v2 01/13] input: move MT_TOOL_* to input-event-codes.h Benjamin Tissoires
2018-06-11 17:16   ` Dmitry Torokhov
2018-06-07  7:54 ` Benjamin Tissoires [this message]
2018-06-11 17:18   ` [PATCH v2 02/13] input: add MT_TOOL_DIAL Dmitry Torokhov
2018-06-07  7:54 ` [PATCH v2 03/13] HID: multitouch: make sure the static list of class is not changed Benjamin Tissoires
2018-06-07  7:54 ` [PATCH v2 04/13] HID: multitouch: Store per collection multitouch data Benjamin Tissoires
2018-06-07  7:54 ` [PATCH v2 05/13] HID: multitouch: store a per application quirks value Benjamin Tissoires
2018-06-07  7:54 ` [PATCH v2 06/13] HID: multitouch: ditch mt_report_id Benjamin Tissoires
2018-06-07  7:54 ` [PATCH v2 07/13] HID: multitouch: remove one copy of values Benjamin Tissoires
2018-06-07  7:54 ` [PATCH v2 08/13] HID: input: enable Totem on the Dell Canvas 27 Benjamin Tissoires
2018-06-07  7:54 ` [PATCH v2 09/13] HID: core: do not upper bound the collection stack Benjamin Tissoires
2018-06-07  7:54 ` [PATCH v2 10/13] HID: microsoft: support the Surface Dial Benjamin Tissoires
2018-06-07  7:54 ` [PATCH v2 11/13] HID: multitouch: report MT_TOOL_PALM for non-confident touches Benjamin Tissoires
2018-06-07  7:54 ` [PATCH v2 12/13] HID: multitouch: touchscreens also use confidence reports Benjamin Tissoires
2018-06-07  7:54 ` [PATCH v2 13/13] HID: multitouch: handle palm for touchscreens Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607075448.5706-3-benjamin.tissoires@redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=Mario.Limonciello@dell.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.hutterer@who-t.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).