From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
jgross@suse.com, lyan@suse.com, boris.ostrovsky@oracle.com
Cc: konrad.wilk@oracle.com, andr2000@gmail.com,
andrii_chepurnyi@epam.com,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v5 2/3] Input: xen-kbdfront - fix multi-touch XenStore node's locations
Date: Tue, 12 Jun 2018 10:48:55 +0300 [thread overview]
Message-ID: <20180612074856.28451-3-andr2000@gmail.com> (raw)
In-Reply-To: <20180612074856.28451-1-andr2000@gmail.com>
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
kbdif protocol describes multi-touch device parameters as a
part of frontend's XenBus configuration nodes while they
belong to backend's configuration. Fix this by reading the
parameters as defined by the protocol.
Fixes: 49aac8204da5 ("Input: xen-kbdfront - add multi-touch support")
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
drivers/input/misc/xen-kbdfront.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
index d91f3b1c5375..92d739649022 100644
--- a/drivers/input/misc/xen-kbdfront.c
+++ b/drivers/input/misc/xen-kbdfront.c
@@ -229,7 +229,7 @@ static int xenkbd_probe(struct xenbus_device *dev,
}
}
- touch = xenbus_read_unsigned(dev->nodename,
+ touch = xenbus_read_unsigned(dev->otherend,
XENKBD_FIELD_FEAT_MTOUCH, 0);
if (touch) {
ret = xenbus_write(XBT_NIL, dev->nodename,
@@ -304,13 +304,13 @@ static int xenkbd_probe(struct xenbus_device *dev,
if (!mtouch)
goto error_nomem;
- num_cont = xenbus_read_unsigned(info->xbdev->nodename,
+ num_cont = xenbus_read_unsigned(info->xbdev->otherend,
XENKBD_FIELD_MT_NUM_CONTACTS,
1);
- width = xenbus_read_unsigned(info->xbdev->nodename,
+ width = xenbus_read_unsigned(info->xbdev->otherend,
XENKBD_FIELD_MT_WIDTH,
XENFB_WIDTH);
- height = xenbus_read_unsigned(info->xbdev->nodename,
+ height = xenbus_read_unsigned(info->xbdev->otherend,
XENKBD_FIELD_MT_HEIGHT,
XENFB_HEIGHT);
--
2.17.1
next prev parent reply other threads:[~2018-06-12 7:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 7:48 [PATCH v5 0/3] Input: xen-kbdfront - allow better run-time configuration Oleksandr Andrushchenko
2018-06-12 7:48 ` [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen Oleksandr Andrushchenko
2018-06-12 13:46 ` Juergen Gross
2018-06-12 13:47 ` Oleksandr Andrushchenko
2018-06-12 23:40 ` Dmitry Torokhov
2018-06-13 5:49 ` Oleksandr Andrushchenko
2018-06-13 6:11 ` Dmitry Torokhov
2018-06-13 6:13 ` Oleksandr Andrushchenko
2018-06-13 6:25 ` Dmitry Torokhov
2018-06-13 6:28 ` Oleksandr Andrushchenko
2018-06-13 6:40 ` Juergen Gross
2018-06-13 6:43 ` Oleksandr Andrushchenko
2018-06-12 7:48 ` Oleksandr Andrushchenko [this message]
2018-06-12 13:47 ` [PATCH v5 2/3] Input: xen-kbdfront - fix multi-touch XenStore node's locations Juergen Gross
2018-06-12 7:48 ` [PATCH v5 3/3] Input: xen-kbdfront - allow better run-time configuration Oleksandr Andrushchenko
2018-06-12 13:50 ` Juergen Gross
2018-06-12 22:07 ` Dmitry Torokhov
2018-06-13 5:47 ` Oleksandr Andrushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612074856.28451-3-andr2000@gmail.com \
--to=andr2000@gmail.com \
--cc=andrii_chepurnyi@epam.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyan@suse.com \
--cc=oleksandr_andrushchenko@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).