From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: cros_ec_keyb: remove redundant variable num_cols Date: Wed, 4 Jul 2018 15:55:10 +0000 Message-ID: <20180704155510.b7q2zy4zehwumngc@penguin> References: <20180702162841.12553-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20180702162841.12553-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Colin King Cc: Ravi Chandra Sadineni , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org On Mon, Jul 02, 2018 at 05:28:41PM +0100, Colin King wrote: > From: Colin Ian King > > Variable num_cols is being assigned but is never used hence it is > redundant and can be removed. > > Cleans up clang warning: > warning: variable ‘num_cols’ set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King Applied, thank you. > --- > drivers/input/keyboard/cros_ec_keyb.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c > index 820bebad519a..81be6f781f0b 100644 > --- a/drivers/input/keyboard/cros_ec_keyb.c > +++ b/drivers/input/keyboard/cros_ec_keyb.c > @@ -160,9 +160,6 @@ static void cros_ec_keyb_process(struct cros_ec_keyb *ckdev, > int col, row; > int new_state; > int old_state; > - int num_cols; > - > - num_cols = len; > > if (ckdev->ghost_filter && cros_ec_keyb_has_ghosting(ckdev, kb_state)) { > /* > -- > 2.17.1 > -- Dmitry