From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Christian Thoms <christian.thoms93@gmail.com>
Cc: rydberg@bitmath.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kernel@i4.cs.fau.de,
Sebastian Hillert <sebastian.hillert1@gmail.com>
Subject: Re: [PATCH] drivers: input: Add SPDX-License-Identifier
Date: Wed, 18 Jul 2018 16:13:55 +0000 [thread overview]
Message-ID: <20180718161355.o7nct5jcxh4xqmgz@penguin> (raw)
In-Reply-To: <1530879112-3388-1-git-send-email-christian.thoms93@gmail.com>
Hi Christian,
On Fri, Jul 06, 2018 at 02:11:52PM +0200, Christian Thoms wrote:
> diff --git a/drivers/input/ff-core.c b/drivers/input/ff-core.c
> index 66a46c8..3086166 100644
> --- a/drivers/input/ff-core.c
> +++ b/drivers/input/ff-core.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0+
> /*
> * Force feedback support for Linux input subsystem
> *
> @@ -6,11 +7,6 @@
> */
>
> /*
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> * This program is distributed in the hope that it will be useful,
> * but WITHOUT ANY WARRANTY; without even the implied warranty of
> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Why did you keep this block here? Also, below, there is another
paragraph about obtaining a copy of GPL from an old FSF address. If we
are cleaning it I believe it all needs to go.
I see the similar issue in several other files in this patch.
Thanks.
--
Dmitry
prev parent reply other threads:[~2018-07-18 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 12:11 [PATCH] drivers: input: Add SPDX-License-Identifier Christian Thoms
2018-07-18 16:13 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718161355.o7nct5jcxh4xqmgz@penguin \
--to=dmitry.torokhov@gmail.com \
--cc=christian.thoms93@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@bitmath.org \
--cc=sebastian.hillert1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox