From mboxrd@z Thu Jan 1 00:00:00 1970 From: dev-harsh1998 Subject: [PATCH 02/11] touchscreen: ad7877: Use octal permissions Date: Sun, 22 Jul 2018 00:39:42 +0530 Message-ID: <20180721191029.25658-1-harshitjain6751@gmail.com> Return-path: Sender: linux-kernel-owner@vger.kernel.org To: trivial@kernel.org Cc: Michael Hennerich , Dmitry Torokhov , Simon Budig , Andi Shyti , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/ad7877.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c index 5cfe477ec992..4b4a9d84195e 100644 --- a/drivers/input/touchscreen/ad7877.c +++ b/drivers/input/touchscreen/ad7877.c @@ -461,7 +461,7 @@ name ## _show(struct device *dev, struct device_attribute *attr, char *buf) \ return v; \ return sprintf(buf, "%u\n", (unsigned) v); \ } \ -static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); +static DEVICE_ATTR(name, 0444, name ## _show, NULL); SHOW(aux1) SHOW(aux2) -- 2.17.1