From: dev-harsh1998 <harshitjain6751@gmail.com>
To: trivial@kernel.org
Cc: Harshit Jain <harshitjain6751@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Simon Budig <simon.budig@kernelconcepts.de>,
Andi Shyti <andi@etezian.org>,
Luca Ceresoli <luca@lucaceresoli.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joe Perches <joe@perches.com>, Guenter Roeck <linux@roeck-us.net>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 05/11] touchscreen: elants: Use octal permissions
Date: Mon, 23 Jul 2018 18:49:20 +0530 [thread overview]
Message-ID: <20180723131954.30739-4-harshitjain6751@gmail.com> (raw)
In-Reply-To: <20180723131954.30739-1-harshitjain6751@gmail.com>
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
+static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL);
WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'.
+static DEVICE_ATTR(update_fw, S_IWUSR, NULL, write_update_fw)
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
+ .dattr = __ATTR(_field, S_IRUGO, \
Signed-off-by: Harshit Jain <harshitjain6751@gmail.com>
---
drivers/input/touchscreen/elants_i2c.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index d21ca39b0fdb..9717b7c3bb6f 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -1000,8 +1000,8 @@ static ssize_t show_iap_mode(struct device *dev,
}
static DEVICE_ATTR_WO(calibrate);
-static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL);
-static DEVICE_ATTR(update_fw, S_IWUSR, NULL, write_update_fw);
+static DEVICE_ATTR(iap_mode, 0444, show_iap_mode, NULL);
+static DEVICE_ATTR(update_fw, 0200, NULL, write_update_fw);
struct elants_version_attribute {
struct device_attribute dattr;
@@ -1016,7 +1016,7 @@ struct elants_version_attribute {
__ELANTS_FIELD_SIZE(_field))
#define ELANTS_VERSION_ATTR(_field) \
struct elants_version_attribute elants_ver_attr_##_field = { \
- .dattr = __ATTR(_field, S_IRUGO, \
+ .dattr = __ATTR(_field, 0444, \
elants_version_attribute_show, NULL), \
.field_offset = offsetof(struct elants_data, _field), \
.field_size = __ELANTS_VERIFY_SIZE(_field), \
--
2.17.1
next prev parent reply other threads:[~2018-07-23 13:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 13:19 [PATCH 02/11] touchscreen: ad7877: Use octal permissions dev-harsh1998
2018-07-23 13:19 ` [PATCH 03/11] touchscreen: ad7846: " dev-harsh1998
2018-07-23 13:19 ` [PATCH 04/11] touchscreen: amtel: " dev-harsh1998
2018-07-23 13:19 ` dev-harsh1998 [this message]
2018-07-23 13:32 ` [PATCH 05/11] touchscreen: elants: " Greg Kroah-Hartman
2018-07-23 17:18 ` Dmitry Torokhov
2018-07-23 17:25 ` Joe Perches
2018-07-23 17:46 ` Dmitry Torokhov
2018-07-23 18:24 ` Guenter Roeck
2018-07-23 18:30 ` Joe Perches
2018-07-23 20:17 ` Harshit Jain
2018-07-23 13:19 ` [PATCH 06/11] touchscreen: ili210x: " dev-harsh1998
2018-07-23 13:19 ` [PATCH 07/11] touchscreen: mc13783: " dev-harsh1998
2018-07-23 13:19 ` [PATCH 08/11] touchscreen: melfas: " dev-harsh1998
2018-07-23 13:19 ` [PATCH 09/11] touchscreen: raydium_ts: " dev-harsh1998
2018-07-23 13:19 ` [PATCH 10/11] touchscreen: sun4i_ts: " dev-harsh1998
2018-07-23 13:19 ` [PATCH 11/11] touchscreen: tsc200x: " dev-harsh1998
2018-07-23 13:19 ` [PATCH 01/11] touchscreen: ft5x06: " dev-harsh1998
-- strict thread matches above, loose matches on Subject: below --
2018-07-21 19:09 [PATCH 02/11] touchscreen: ad7877: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 05/11] touchscreen: elants: " dev-harsh1998
2018-07-22 9:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723131954.30739-4-harshitjain6751@gmail.com \
--to=harshitjain6751@gmail.com \
--cc=andi@etezian.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luca@lucaceresoli.net \
--cc=simon.budig@kernelconcepts.de \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).