From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: gustavo@embeddedor.com, arvind.yadav.cs@gmail.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: mouse: appletouch: Replace GFP_ATOMIC with GFP_KERNEL
Date: Fri, 27 Jul 2018 11:36:03 -0700 [thread overview]
Message-ID: <20180727183603.GF72640@dtor-ws> (raw)
In-Reply-To: <20180727022618.1007-1-baijiaju1990@gmail.com>
On Fri, Jul 27, 2018 at 10:26:18AM +0800, Jia-Ju Bai wrote:
> atp_open(), atp_recover() and atp_resume() are never
> called in atomic context.
> They call usb_submit_urb() with GFP_ATOMIC, which is not necessary.
> GFP_ATOMIC can be replaced with GFP_KERNEL.
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Applied, thank you.
> ---
> drivers/input/mouse/appletouch.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
> index 032d27983b6c..f593ec96c95f 100644
> --- a/drivers/input/mouse/appletouch.c
> +++ b/drivers/input/mouse/appletouch.c
> @@ -810,7 +810,7 @@ static int atp_open(struct input_dev *input)
> {
> struct atp *dev = input_get_drvdata(input);
>
> - if (usb_submit_urb(dev->urb, GFP_ATOMIC))
> + if (usb_submit_urb(dev->urb, GFP_KERNEL))
> return -EIO;
>
> dev->open = true;
> @@ -976,7 +976,7 @@ static int atp_recover(struct atp *dev)
> if (error)
> return error;
>
> - if (dev->open && usb_submit_urb(dev->urb, GFP_ATOMIC))
> + if (dev->open && usb_submit_urb(dev->urb, GFP_KERNEL))
> return -EIO;
>
> return 0;
> @@ -994,7 +994,7 @@ static int atp_resume(struct usb_interface *iface)
> {
> struct atp *dev = usb_get_intfdata(iface);
>
> - if (dev->open && usb_submit_urb(dev->urb, GFP_ATOMIC))
> + if (dev->open && usb_submit_urb(dev->urb, GFP_KERNEL))
> return -EIO;
>
> return 0;
> --
> 2.17.0
>
--
Dmitry
prev parent reply other threads:[~2018-07-27 18:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 2:26 [PATCH] input: mouse: appletouch: Replace GFP_ATOMIC with GFP_KERNEL Jia-Ju Bai
2018-07-27 18:36 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727183603.GF72640@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=baijiaju1990@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).