From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Pierre-Loup A . Griffais" <pgriffais@valvesoftware.com>,
Juha Kuikka <juha.kuikka@gmail.com>
Subject: [PATCH v2 0/2] Rumble support for Xbox One S controller
Date: Wed, 15 Aug 2018 19:44:08 -0700 [thread overview]
Message-ID: <20180816024410.29218-1-andrew.smirnov@gmail.com> (raw)
Everyone:
This is v2 of the patches adding support for rumble for Xbox One S
controller connected over Bluetooth. Hopefully all of the changes are
pretty straightforward and self-explanatory.
Feedback is wellcome!
Changes since [v1]:
- code converting the driver to use struct ms_data is split into a
separate patch
- CONFIG_MICROSOFT_FF removed
- explicit PID comparison replaced with MS_QUIRK_FF
- ms_init_ff() converted to be a no-op for devices that don't have FF
- all FF cleanup actions moved into ms_remove_ff()
- struct xb1s_ff_report declared to be packed, magic 4 replaced
with MAGNITUDE_NUM, output_report_dmabuf converted to be void *
to avoid the need to typecast it.
Thanks,
Andrey Smirnov
[v1] lkml.kernel.org/r/20180810001714.14659-1-andrew.smirnov@gmail.com
Andrey Smirnov (2):
hid: microsoft: Convert private data to be a proper struct
hid: microsoft: Add rumble support for Xbox One S controller
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-microsoft.c | 142 ++++++++++++++++++++++++++++++++++--
2 files changed, 138 insertions(+), 5 deletions(-)
--
2.17.1
next reply other threads:[~2018-08-16 2:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 2:44 Andrey Smirnov [this message]
2018-08-16 2:44 ` [PATCH v2 1/2] hid: microsoft: Convert private data to be a proper struct Andrey Smirnov
2018-08-16 2:44 ` [PATCH v2 2/2] hid: microsoft: Add rumble support for Xbox One S controller Andrey Smirnov
2018-09-05 8:20 ` [PATCH v2 0/2] Rumble " Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816024410.29218-1-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=juha.kuikka@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pgriffais@valvesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).