From: Lee Jones <lee.jones@linaro.org>
To: RaviChandra Sadineni <ravisadineni@chromium.org>
Cc: dmitry.torokhov@gmail.com, ravisadineni@google.com,
dtor@google.com, linux-samsung-soc@vger.kernel.org,
tbroch@google.com, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, tfiga@chromium.org,
m.szyprowski@samsung.com
Subject: Re: mfd: cros_ec: Check for mkbp events on resume only if supported.
Date: Mon, 10 Sep 2018 15:37:44 +0100 [thread overview]
Message-ID: <20180910143744.GT28860@dell> (raw)
In-Reply-To: <20180820153419.32098-1-ravisadineni@google.com>
On Mon, 20 Aug 2018, RaviChandra Sadineni wrote:
> Currently on every resume we check for mkbp events and notify the
> clients. This helps in identifying the wakeup sources. But on devices
> that do not support mkbp protocol, we might end up querying key state of
> the keyboard in a loop which blocks the resume. Instead check for events
> only if mkbp is supported.
>
> Signed-off-by: RaviChandra Sadineni <ravisadineni@chromium.org>
> ---
>
> Note: This patch fixes the suspend/resume issue on Snow and Peach-Pit
> Chromebooks, both on vanilla v4.18 as well as linux-next from 20 August
> 2018. Further info at: https://lkml.org/lkml/2018/6/5/1076
>
> drivers/mfd/cros_ec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2018-09-10 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180820153427epcas3p366f998ada5f2f37f1198a1321e9e10be@epcas3p3.samsung.com>
2018-08-20 15:34 ` mfd: cros_ec: Check for mkbp events on resume only if supported RaviChandra Sadineni
2018-08-21 7:28 ` Marek Szyprowski
2018-09-10 14:37 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910143744.GT28860@dell \
--to=lee.jones@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=ravisadineni@chromium.org \
--cc=ravisadineni@google.com \
--cc=tbroch@google.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).