From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
linux-input@vger.kernel.org, debian-68k@lists.debian.org,
linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour
Date: Mon, 17 Sep 2018 15:36:27 -0700 [thread overview]
Message-ID: <20180917223627.GC203020@dtor-ws> (raw)
In-Reply-To: <87in33hnqj.fsf@igel.home>
On Mon, Sep 17, 2018 at 10:29:08PM +0200, Andreas Schwab wrote:
> On Sep 17 2018, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> > On Fri, Sep 07, 2018 at 11:40:43AM +1200, Michael Schmitz wrote:
> >> The CapsLock key on Atari keyboards is not a toggle, it does send the
> >> normal make and break scancodes.
> >>
> >> Drop the CapsLock toggle handling code, which did cause the CapsLock
> >> key to merely act as a Shift key.
> >>
> >> Tested-by: Michael Schmitz <schmitzmic@gmail.com>
> >> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
> >
> > Andreas, I have no idea how Atari keyboards work, can you add your
> > signed-off-by (or NAK) to this one as well please?
>
> The old atakbd driver never had that special handling.
>
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
Applied, thank you.
next prev parent reply other threads:[~2018-09-17 22:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 23:40 [PATCH 0/2] input: atakbd.c bug fixes Michael Schmitz
2018-09-06 23:40 ` [PATCH 1/2] input: atakbd.c - fix Atari keymap Michael Schmitz
2018-09-07 0:26 ` Finn Thain
2018-09-07 9:22 ` Andreas Schwab
2018-09-08 8:06 ` Michael Schmitz
2018-09-06 23:40 ` [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour Michael Schmitz
2018-09-17 19:43 ` Dmitry Torokhov
2018-09-17 20:29 ` Andreas Schwab
2018-09-17 22:36 ` Dmitry Torokhov [this message]
2018-09-18 2:03 ` Michael Schmitz
2018-09-18 17:08 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917223627.GC203020@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=debian-68k@lists.debian.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=schmitzmic@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox