From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heikki Krogerus Subject: Re: [RFC/PATCH 2/5] device property: introduce notion of subnodes for legacy boards Date: Mon, 24 Sep 2018 10:29:53 +0300 Message-ID: <20180924072953.GH11965@kuha.fi.intel.com> References: <20180917181603.125492-1-dmitry.torokhov@gmail.com> <20180917181603.125492-3-dmitry.torokhov@gmail.com> <20180919151026.GB11965@kuha.fi.intel.com> <20180919171326.GB116719@dtor-ws> <20180920101648.GC11965@kuha.fi.intel.com> <20180921233336.GB44099@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180921233336.GB44099@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov Cc: Linus Walleij , "Rafael J . Wysocki" , linux-input@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko List-Id: linux-input@vger.kernel.org On Fri, Sep 21, 2018 at 04:33:36PM -0700, Dmitry Torokhov wrote: > On Thu, Sep 20, 2018 at 01:16:48PM +0300, Heikki Krogerus wrote: > > On Wed, Sep 19, 2018 at 10:13:26AM -0700, Dmitry Torokhov wrote: > > > > > diff --git a/drivers/base/pset_property.c b/drivers/base/pset_property.c > > > > > index 08ecc13080ae..63f2377aefe8 100644 > > > > > --- a/drivers/base/pset_property.c > > > > > +++ b/drivers/base/pset_property.c > > > > > @@ -18,6 +18,11 @@ struct property_set { > > > > > struct device *dev; > > > > > struct fwnode_handle fwnode; > > > > > const struct property_entry *properties; > > > > > + > > > > > + struct property_set *parent; > > > > > + /* Entry in parent->children list */ > > > > > + struct list_head child_node; > > > > > + struct list_head children; > > > > > > > > Add > > > > > > > > const char *name; > > > > > > > > and you can implement also pset_get_named_child_node(). > > > > > > Or > > > char name[]; > > > > > > to avoid separate allocation. > > > > Let's not do that, especially if you are planning on exporting this > > structure. > > Can you please elaborate why? Not using pointer saves us 4/8 bytes + > however much memory we need for bookkeeping for the extra chunk. Given > that majority of pset nodes are unnamed this seems wasteful. > > > If the name is coming from .rodata, there is no need to > > allocate anything for the name. Check kstrdup_const(). > > The data is most likely coming as __initconst so we do need to copy it. OK, I did not consider that. Yes, it makes sense to always copy. Thanks, -- heikki