* [PATCH] Input: evdev - add a schedule point in evdev_write()
@ 2018-10-05 0:53 Dmitry Torokhov
2018-10-05 4:08 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2018-10-05 0:53 UTC (permalink / raw)
To: linux-input; +Cc: Eric Dumazet, Paul E. McKenney, linux-kernel
Large writes to evdev interface may cause rcu stalls. Let's add
cond_resched() to the loop to avoid this.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/evdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index 370206f987f9..f48369d6f3a0 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -564,6 +564,7 @@ static ssize_t evdev_write(struct file *file, const char __user *buffer,
input_inject_event(&evdev->handle,
event.type, event.code, event.value);
+ cond_resched();
}
out:
--
2.19.0.605.g01d371f741-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: evdev - add a schedule point in evdev_write()
2018-10-05 0:53 [PATCH] Input: evdev - add a schedule point in evdev_write() Dmitry Torokhov
@ 2018-10-05 4:08 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2018-10-05 4:08 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, Eric Dumazet, linux-kernel
On Thu, Oct 04, 2018 at 05:53:59PM -0700, Dmitry Torokhov wrote:
> Large writes to evdev interface may cause rcu stalls. Let's add
> cond_resched() to the loop to avoid this.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.ibm.com>
> ---
> drivers/input/evdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
> index 370206f987f9..f48369d6f3a0 100644
> --- a/drivers/input/evdev.c
> +++ b/drivers/input/evdev.c
> @@ -564,6 +564,7 @@ static ssize_t evdev_write(struct file *file, const char __user *buffer,
>
> input_inject_event(&evdev->handle,
> event.type, event.code, event.value);
> + cond_resched();
> }
>
> out:
> --
> 2.19.0.605.g01d371f741-goog
>
>
> --
> Dmitry
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-05 4:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-05 0:53 [PATCH] Input: evdev - add a schedule point in evdev_write() Dmitry Torokhov
2018-10-05 4:08 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).