* [PATCH] Input: uinput - add a schedule point in uinput_inject_events()
@ 2018-10-05 0:54 Dmitry Torokhov
2018-10-05 4:09 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2018-10-05 0:54 UTC (permalink / raw)
To: linux-input; +Cc: Eric Dumazet, Paul E. McKenney, linux-kernel
Large writes to uinput interface may cause rcu stalls. Let's add
cond_resched() to the loop to avoid this.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/misc/uinput.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index eb14ddf69346..8ec483e8688b 100644
--- a/drivers/input/misc/uinput.c
+++ b/drivers/input/misc/uinput.c
@@ -598,6 +598,7 @@ static ssize_t uinput_inject_events(struct uinput_device *udev,
input_event(udev->dev, ev.type, ev.code, ev.value);
bytes += input_event_size();
+ cond_resched();
}
return bytes;
--
2.19.0.605.g01d371f741-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: uinput - add a schedule point in uinput_inject_events()
2018-10-05 0:54 [PATCH] Input: uinput - add a schedule point in uinput_inject_events() Dmitry Torokhov
@ 2018-10-05 4:09 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2018-10-05 4:09 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, Eric Dumazet, linux-kernel
On Thu, Oct 04, 2018 at 05:54:32PM -0700, Dmitry Torokhov wrote:
> Large writes to uinput interface may cause rcu stalls. Let's add
> cond_resched() to the loop to avoid this.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.ibm.com>
> ---
> drivers/input/misc/uinput.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
> index eb14ddf69346..8ec483e8688b 100644
> --- a/drivers/input/misc/uinput.c
> +++ b/drivers/input/misc/uinput.c
> @@ -598,6 +598,7 @@ static ssize_t uinput_inject_events(struct uinput_device *udev,
>
> input_event(udev->dev, ev.type, ev.code, ev.value);
> bytes += input_event_size();
> + cond_resched();
> }
>
> return bytes;
> --
> 2.19.0.605.g01d371f741-goog
>
>
> --
> Dmitry
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-05 4:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-05 0:54 [PATCH] Input: uinput - add a schedule point in uinput_inject_events() Dmitry Torokhov
2018-10-05 4:09 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).