* [PATCH v2] dt-bindings: input: pwm-vibrator: correct pwms in example
@ 2018-09-27 0:48 Brian Masney
2018-09-27 6:45 ` Sebastian Reichel
2018-10-12 19:31 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Brian Masney @ 2018-09-27 0:48 UTC (permalink / raw)
To: robh, dmitry.torokhov, linux-input, devicetree, linux-kernel,
sebastian.reichel, mark.rutland
Cc: masneyb
In the example for the pwm-vibrator bindings, pwm8 is the direction pin,
and pwm9 is the enable pin. The pwms on the vibrator node has these two
values swapped so this patch corrects it.
Signed-off-by: Brian Masney <masneyb@onstation.org>
---
Changes since v1:
- Swapped the pwms values instead of the pwm-names values since enable
is required and direction is optional. Based on feedback from
Rob Herring.
Documentation/devicetree/bindings/input/pwm-vibrator.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/pwm-vibrator.txt b/Documentation/devicetree/bindings/input/pwm-vibrator.txt
index 09145d18491d..88c775a3fe21 100644
--- a/Documentation/devicetree/bindings/input/pwm-vibrator.txt
+++ b/Documentation/devicetree/bindings/input/pwm-vibrator.txt
@@ -58,8 +58,8 @@ Example from Motorola Droid 4:
vibrator {
compatible = "pwm-vibrator";
- pwms = <&pwm8 0 1000000000 0>,
- <&pwm9 0 1000000000 0>;
+ pwms = <&pwm9 0 1000000000 0>,
+ <&pwm8 0 1000000000 0>;
pwm-names = "enable", "direction";
direction-duty-cycle-ns = <1000000000>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] dt-bindings: input: pwm-vibrator: correct pwms in example
2018-09-27 0:48 [PATCH v2] dt-bindings: input: pwm-vibrator: correct pwms in example Brian Masney
@ 2018-09-27 6:45 ` Sebastian Reichel
2018-10-12 19:31 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2018-09-27 6:45 UTC (permalink / raw)
To: Brian Masney
Cc: robh, dmitry.torokhov, linux-input, devicetree, linux-kernel,
mark.rutland
[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]
Hi,
On Wed, Sep 26, 2018 at 08:48:58PM -0400, Brian Masney wrote:
> In the example for the pwm-vibrator bindings, pwm8 is the direction pin,
> and pwm9 is the enable pin. The pwms on the vibrator node has these two
> values swapped so this patch corrects it.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---
>
> Changes since v1:
> - Swapped the pwms values instead of the pwm-names values since enable
> is required and direction is optional. Based on feedback from
> Rob Herring.
>
> Documentation/devicetree/bindings/input/pwm-vibrator.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/pwm-vibrator.txt b/Documentation/devicetree/bindings/input/pwm-vibrator.txt
> index 09145d18491d..88c775a3fe21 100644
> --- a/Documentation/devicetree/bindings/input/pwm-vibrator.txt
> +++ b/Documentation/devicetree/bindings/input/pwm-vibrator.txt
> @@ -58,8 +58,8 @@ Example from Motorola Droid 4:
>
> vibrator {
> compatible = "pwm-vibrator";
> - pwms = <&pwm8 0 1000000000 0>,
> - <&pwm9 0 1000000000 0>;
> + pwms = <&pwm9 0 1000000000 0>,
> + <&pwm8 0 1000000000 0>;
> pwm-names = "enable", "direction";
> direction-duty-cycle-ns = <1000000000>;
> };
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] dt-bindings: input: pwm-vibrator: correct pwms in example
2018-09-27 0:48 [PATCH v2] dt-bindings: input: pwm-vibrator: correct pwms in example Brian Masney
2018-09-27 6:45 ` Sebastian Reichel
@ 2018-10-12 19:31 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2018-10-12 19:31 UTC (permalink / raw)
Cc: robh, dmitry.torokhov, linux-input, devicetree, linux-kernel,
sebastian.reichel, mark.rutland, masneyb
On Wed, 26 Sep 2018 20:48:58 -0400, Brian Masney wrote:
> In the example for the pwm-vibrator bindings, pwm8 is the direction pin,
> and pwm9 is the enable pin. The pwms on the vibrator node has these two
> values swapped so this patch corrects it.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---
> Changes since v1:
> - Swapped the pwms values instead of the pwm-names values since enable
> is required and direction is optional. Based on feedback from
> Rob Herring.
>
> Documentation/devicetree/bindings/input/pwm-vibrator.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-12 19:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-27 0:48 [PATCH v2] dt-bindings: input: pwm-vibrator: correct pwms in example Brian Masney
2018-09-27 6:45 ` Sebastian Reichel
2018-10-12 19:31 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).