From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] HID: quirks: fix support for Apple Magic Keyboards Date: Wed, 17 Oct 2018 18:55:10 +0200 Message-ID: <20181017165510.GA7468@kroah.com> References: <20181017145201.7105-1-ncopa@alpinelinux.org> <20181017175515.798b2316@ncopa-desktop.copa.dup.pw> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org To: Benjamin Tissoires Cc: ncopa@alpinelinux.org, linux stable , "open list:HID CORE LAYER" , Jiri Kosina , seobrien@chromium.org List-Id: linux-input@vger.kernel.org On Wed, Oct 17, 2018 at 06:49:16PM +0200, Benjamin Tissoires wrote: > On Wed, Oct 17, 2018 at 5:55 PM Natanael Copa wrote: > > > > On Wed, 17 Oct 2018 16:59:15 +0200 > > Benjamin Tissoires wrote: > > > > > Hi Natanael, > > > > > > On Wed, Oct 17, 2018 at 4:52 PM Natanael Copa wrote: > > > > > > > > Commit ee3454924370 ("HID: add support for Apple Magic Keyboards") added > > > > support for the Magic Keyboard over Bluetooth, but did not add the > > > > BT_VENDOR_ID_APPLE to hid-quirks. Fix this so hid-apple driver is used > > > > over hid-generic. > > > > > > > > This fixes the Fn key, which does not work at all with hid-generic. > > > > > > > > Fixes: ee3454924370 ("HID: add support for Apple Magic Keyboards") > > > > Bugzilla-id: https://bugzilla.kernel.org/show_bug.cgi?id=99881 > > > > Signed-off-by: Natanael Copa > > > > --- > > > > This should be backported to stable too. > > > > > > > > drivers/hid/hid-quirks.c | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > > > > > diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c > > > > index 249d49b6b16c..a3b3aecf8628 100644 > > > > --- a/drivers/hid/hid-quirks.c > > > > +++ b/drivers/hid/hid-quirks.c > > > > @@ -270,6 +270,9 @@ static const struct hid_device_id hid_have_special_driver[] = { > > > > { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ISO) }, > > > > { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_JIS) }, > > > > { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_ANSI) }, > > > > + { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_ANSI) }, > > > > + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_ANSI) }, > > > > + { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_ANSI) }, > > > > > > NACK, this should not be required with kernels v4.17+ IIRC. > > > > > > If it doesn't work on a recent kernel, please raise the issue, but I > > > am actually chasing down the new inclusions of these when we add new > > > device support. > > > > Fair enough. I think it may be needed for 4.14.y kernels though, to fix > > commit b6cc0ba2cbf4 (HID: add support for Apple Magic Keyboards). > > > > Fn key did not work without this patch on 4.14.76 for me. > > Right, b6cc0ba2cbf4 has been added to 4.14.75 and is not working > because tweaking hid_have_special_driver[] is not required in current > kernels anymore. > > @stable folks, would it be possible to take this patch in the v4.9 and > v4.14 trees? It can't go into Linus' tree, but I'd be glad to give my > Acked-by for a stable backport. Sure, if you resend it in a format that I can apply it in, with the text saying why this is not applicable to newer kernel versions. thanks, greg k-h