From: Henrique de Moraes Holschuh <hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
To: Jaak Ristioja <jaak-89mTbI93R4uuvFJfX82//w@public.gmane.org>
Cc: "Alexander Kappner" <agk-mA9ux5SlULTR7s880joybQ@public.gmane.org>,
"Jouke Witteveen"
<j.witteveen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
"Pali Rohár" <pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Andy Shevchenko"
<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: 2nd Fan quirk for Thinkpad P50 causes spurios touchpad/trackpoint events on ThinkPad L570
Date: Tue, 23 Oct 2018 00:47:32 -0300 [thread overview]
Message-ID: <20181023034732.otali4g2sbdrbdk6@khazad-dum.debian.net> (raw)
In-Reply-To: <36111ed4-621c-47a8-bc6a-66cf756a0ac6-89mTbI93R4uuvFJfX82//w@public.gmane.org>
On Sat, 13 Oct 2018, Jaak Ristioja wrote:
> On 27.08.2018 19:22, Jaak Ristioja wrote:
> > Upgrading Linux from 4.16 to 4.17, a ThinkPad L570 started receiving
> > spurious input events, mostly right mouse button click events, but also
> > cursor jumps.
> >
> > I have not attempted to understand whether these events come from the
> > trackpoint or touchpad or some other driver, but I managed to bisect
> > this issue to commit a986c75a7df0 titled "platform/x86: thinkpad_acpi:
> > Add 2nd Fan Support for Thinkpad P50" by Alexander Kappner.
> >
> > Apparently the quirk mitigation is applied when the BIOS version begins
> > with N1. The BIOS version on the L570 in question is N1XET57W (1.35 )
> > which is probably why this commit causes the described problems on the
> > ThinkPad L570. How exactly? - I don't know.
> >
> > The issue did not reproduce when running some stable 4.17 and 4.18
> > kernels with commit a986c75a7df0 reverted.
> >
> > Please fix this for future kernels. Thanks! :)
>
> Ping. Do you need any additional information?
It looks like it is failing to detect N1X and N1 as different models,
the bug is likely on this commit:
commit 846a416b4630fc960c10500b4194ad504bc22d4b
platform/x86: thinkpad_acpi: Proper model/release matching
Real life has been **extremely** busy, so I'd appreciate a patch.
Otherwise I will eventually get to it, but it might take a few
weeks(!!).
--
Henrique Holschuh
prev parent reply other threads:[~2018-10-23 3:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <eee05e84-42ed-a6ad-65c6-f5b2fe7cdd27@ristioja.ee>
[not found] ` <36111ed4-621c-47a8-bc6a-66cf756a0ac6@ristioja.ee>
[not found] ` <36111ed4-621c-47a8-bc6a-66cf756a0ac6-89mTbI93R4uuvFJfX82//w@public.gmane.org>
2018-10-16 0:11 ` 2nd Fan quirk for Thinkpad P50 causes spurios touchpad/trackpoint events on ThinkPad L570 Dmitry Torokhov
[not found] ` <CAKdAkRTbQ+-+h8SMGf9Khc4+wE+P3_UCbYR0DDi1MoBwfSOWZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-10-23 3:50 ` Henrique de Moraes Holschuh
[not found] ` <20181023035007.iy5vy2z3vuto2d6s-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2018-10-23 8:16 ` Jouke Witteveen
[not found] ` <CAJ2ouawfddrf8K22auR4OaJkO_n5f-rme=+XrbQYNo0eJfCtQA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-10-24 0:47 ` Henrique de Moraes Holschuh
2018-10-23 3:47 ` Henrique de Moraes Holschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023034732.otali4g2sbdrbdk6@khazad-dum.debian.net \
--to=hmh-n3tv7giv+o9fyo9q7ep/yw@public.gmane.org \
--cc=agk-mA9ux5SlULTR7s880joybQ@public.gmane.org \
--cc=andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=j.witteveen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jaak-89mTbI93R4uuvFJfX82//w@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox