linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Jiri Kosina <jikos@kernel.org>, Harry Cutts <hcutts@chromium.org>,
	Peter Hutterer <peter.hutterer@who-t.net>,
	torvalds@linux-foundation.org
Cc: Nestor Lopez Casado <nlopezcasad@logitech.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH 0/7] HID: revert the Logitech High Resolution wheel support
Date: Wed, 21 Nov 2018 16:27:05 +0100	[thread overview]
Message-ID: <20181121152712.6770-1-benjamin.tissoires@redhat.com> (raw)

It turns out that the implementation of the high resolution support of
Logitech wheels is rather incompatible with the mice from Microsoft.

We had a lengthy discussion off-list and the summary is quoted in 7/7.

The TL;DR, we need to revert the current series before it gets out in
a released kernel and work on a better approach for 4.21.

This patch series has informally been acked by Dmitry, Harry, Jiri, Nestor
and Peter, but I wouldn't mind a public ack before I push this to
the for-linus branch.

Dmitry, I chose to also revert "Input: Add the `REL_WHEEL_HI_RES` event code"
as the documentation needs to be updated.
I would understand if you rather keep the patch that way and we just update
the doc. This would help synchronizing the trees. So please tell me if you
want 7/7 in the series or not (I'll reshuffle the commit message to have
the summary from Peter).

Cheers,
Benjamin

Benjamin Tissoires (7):
  Revert "HID: input: simplify/fix high-res scroll event handling"
  Revert "HID: logitech: fix a used uninitialized GCC warning"
  Revert "HID: logitech: Use LDJ_DEVICE macro for existing Logitech
    mice"
  Revert "HID: logitech: Enable high-resolution scrolling on Logitech
    mice"
  Revert "HID: logitech: Add function to enable HID++ 1.0 "scrolling
    acceleration""
  Revert "HID: input: Create a utility class for counting scroll events"
  Revert "Input: Add the `REL_WHEEL_HI_RES` event code"

 Documentation/input/event-codes.rst    |  11 +-
 drivers/hid/hid-input.c                |  44 ----
 drivers/hid/hid-logitech-hidpp.c       | 309 +++----------------------
 include/linux/hid.h                    |  28 ---
 include/uapi/linux/input-event-codes.h |  10 -
 5 files changed, 28 insertions(+), 374 deletions(-)

-- 
2.19.1

             reply	other threads:[~2018-11-21 15:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21 15:27 Benjamin Tissoires [this message]
2018-11-21 15:27 ` [PATCH 1/7] Revert "HID: input: simplify/fix high-res scroll event handling" Benjamin Tissoires
2018-11-21 15:27 ` [PATCH 2/7] Revert "HID: logitech: fix a used uninitialized GCC warning" Benjamin Tissoires
2018-11-21 15:27 ` [PATCH 3/7] Revert "HID: logitech: Use LDJ_DEVICE macro for existing Logitech mice" Benjamin Tissoires
2018-11-21 15:27 ` [PATCH 4/7] Revert "HID: logitech: Enable high-resolution scrolling on " Benjamin Tissoires
2018-11-21 15:27 ` [PATCH 5/7] Revert "HID: logitech: Add function to enable HID++ 1.0 "scrolling acceleration"" Benjamin Tissoires
2018-11-21 15:27 ` [PATCH 6/7] Revert "HID: input: Create a utility class for counting scroll events" Benjamin Tissoires
2018-11-21 15:27 ` [PATCH 7/7] Revert "Input: Add the `REL_WHEEL_HI_RES` event code" Benjamin Tissoires
2018-11-21 18:37 ` [PATCH 0/7] HID: revert the Logitech High Resolution wheel support Harry Cutts
2018-11-21 18:44   ` Dmitry Torokhov
2018-11-21 18:46 ` Jiri Kosina
2018-11-22  8:01 ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181121152712.6770-1-benjamin.tissoires@redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hcutts@chromium.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nlopezcasad@logitech.com \
    --cc=peter.hutterer@who-t.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).