From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jikos@kernel.org>, Harry Cutts <hcutts@chromium.org>,
Peter Hutterer <peter.hutterer@who-t.net>,
torvalds@linux-foundation.org
Cc: Nestor Lopez Casado <nlopezcasad@logitech.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH 2/7] Revert "HID: logitech: fix a used uninitialized GCC warning"
Date: Wed, 21 Nov 2018 16:27:07 +0100 [thread overview]
Message-ID: <20181121152712.6770-3-benjamin.tissoires@redhat.com> (raw)
In-Reply-To: <20181121152712.6770-1-benjamin.tissoires@redhat.com>
This reverts commit 5fe2ccbef9d7aecf5c4402c753444f1a12096cfd.
It turns out the current API is not that compatible with
some Microsoft mice, so better start again from scratch.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/hid-logitech-hidpp.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index f01280898b24..5f0c080059c6 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -1231,6 +1231,7 @@ static int hidpp_hrw_get_wheel_capability(struct hidpp_device *hidpp,
*multiplier = response.fap.params[0];
return 0;
return_default:
+ *multiplier = 8;
hid_warn(hidpp->hid_dev,
"Couldn't get wheel multiplier (error %d), assuming %d.\n",
ret, *multiplier);
@@ -2695,7 +2696,7 @@ static int hi_res_scroll_look_up_microns(__u32 product_id)
static int hi_res_scroll_enable(struct hidpp_device *hidpp)
{
int ret;
- u8 multiplier = 8;
+ u8 multiplier;
if (hidpp->quirks & HIDPP_QUIRK_HI_RES_SCROLL_X2121) {
ret = hidpp_hrw_set_wheel_mode(hidpp, false, true, false);
@@ -2703,9 +2704,10 @@ static int hi_res_scroll_enable(struct hidpp_device *hidpp)
} else if (hidpp->quirks & HIDPP_QUIRK_HI_RES_SCROLL_X2120) {
ret = hidpp_hrs_set_highres_scrolling_mode(hidpp, true,
&multiplier);
- } else /* if (hidpp->quirks & HIDPP_QUIRK_HI_RES_SCROLL_1P0) */
+ } else /* if (hidpp->quirks & HIDPP_QUIRK_HI_RES_SCROLL_1P0) */ {
ret = hidpp10_enable_scrolling_acceleration(hidpp);
-
+ multiplier = 8;
+ }
if (ret)
return ret;
--
2.19.1
next prev parent reply other threads:[~2018-11-21 15:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 15:27 [PATCH 0/7] HID: revert the Logitech High Resolution wheel support Benjamin Tissoires
2018-11-21 15:27 ` [PATCH 1/7] Revert "HID: input: simplify/fix high-res scroll event handling" Benjamin Tissoires
2018-11-21 15:27 ` Benjamin Tissoires [this message]
2018-11-21 15:27 ` [PATCH 3/7] Revert "HID: logitech: Use LDJ_DEVICE macro for existing Logitech mice" Benjamin Tissoires
2018-11-21 15:27 ` [PATCH 4/7] Revert "HID: logitech: Enable high-resolution scrolling on " Benjamin Tissoires
2018-11-21 15:27 ` [PATCH 5/7] Revert "HID: logitech: Add function to enable HID++ 1.0 "scrolling acceleration"" Benjamin Tissoires
2018-11-21 15:27 ` [PATCH 6/7] Revert "HID: input: Create a utility class for counting scroll events" Benjamin Tissoires
2018-11-21 15:27 ` [PATCH 7/7] Revert "Input: Add the `REL_WHEEL_HI_RES` event code" Benjamin Tissoires
2018-11-21 18:37 ` [PATCH 0/7] HID: revert the Logitech High Resolution wheel support Harry Cutts
2018-11-21 18:44 ` Dmitry Torokhov
2018-11-21 18:46 ` Jiri Kosina
2018-11-22 8:01 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121152712.6770-3-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hcutts@chromium.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nlopezcasad@logitech.com \
--cc=peter.hutterer@who-t.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).