From: Lee Jones <lee.jones@linaro.org>
To: Pascal PAILLET-LME <p.paillet@st.com>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"benjamin.gaignard@linaro.org" <benjamin.gaignard@linaro.org>,
"eballetbo@gmail.com" <eballetbo@gmail.com>,
"axel.lin@ingics.com" <axel.lin@ingics.com>
Subject: Re: [PATCH v5 2/8] mfd: stpmic1: add stpmic1 driver
Date: Tue, 27 Nov 2018 08:57:42 +0000 [thread overview]
Message-ID: <20181127085742.GG4272@dell> (raw)
In-Reply-To: <5BFC2B69.1050204@st.com>
On Mon, 26 Nov 2018, Pascal PAILLET-LME wrote:
> Hi Lee,
> I have just one question regarding i2c_device_id.
Don't forget to trim your responses.
Lots of unrequired quotes here.
[...]
> >> +static const struct i2c_device_id stpmic1_id[] = {
> >> + { "stpmic1"},
> >> + {}
> >> +};
> > I don't think this is required any more.
> should I replace with the following ?
>
> static const struct of_device_id stpmic1_of_match[] = {
> { .compatible = "st,stpmic1", },
> {},
> };
> MODULE_DEVICE_TABLE(of, stpmic1_of_match);
I think it should have had that already. So yes, please.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-11-27 8:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 16:22 [PATCH v5 0/8] Introduce STPMIC1 PMIC Driver Pascal PAILLET-LME
2018-10-29 16:22 ` [PATCH v5 1/8] dt-bindings: mfd: document stpmic1 Pascal PAILLET-LME
2018-10-30 19:32 ` Rob Herring
2018-11-13 7:29 ` Lee Jones
2018-10-29 16:22 ` [PATCH v5 3/8] dt-bindings: regulator: document stpmic1 pmic regulators Pascal PAILLET-LME
2018-10-30 19:34 ` Rob Herring
2018-10-29 16:22 ` [PATCH v5 2/8] mfd: stpmic1: add stpmic1 driver Pascal PAILLET-LME
2018-11-13 7:40 ` Lee Jones
2018-11-26 17:20 ` Pascal PAILLET-LME
2018-11-27 8:57 ` Lee Jones [this message]
2018-10-29 16:22 ` [PATCH v5 6/8] input: stpmic1: add stpmic1 onkey driver Pascal PAILLET-LME
2018-10-29 16:22 ` [PATCH v5 4/8] regulator: stpmic1: add stpmic1 regulator driver Pascal PAILLET-LME
2018-10-29 16:22 ` [PATCH v5 5/8] dt-bindings: input: document stpmic1 pmic onkey Pascal PAILLET-LME
2018-10-29 16:22 ` [PATCH v5 8/8] watchdog: stpmic1: add stpmic1 watchdog driver Pascal PAILLET-LME
2018-10-30 13:17 ` Guenter Roeck
2018-10-29 16:22 ` [PATCH v5 7/8] dt-bindings: watchdog: document stpmic1 pmic watchdog Pascal PAILLET-LME
2018-10-30 13:17 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127085742.GG4272@dell \
--to=lee.jones@linaro.org \
--cc=axel.lin@ingics.com \
--cc=benjamin.gaignard@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=p.paillet@st.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).