* [PATCH RESEND] Input: synaptics - enable RMI on ThinkPad T560
@ 2018-12-08 21:44 Yussuf Khalil
2018-12-09 4:13 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Yussuf Khalil @ 2018-12-08 21:44 UTC (permalink / raw)
To: dmitry.torokhov
Cc: benjamin.tissoires, teika, linux-input, linux-kernel,
Yussuf Khalil
Before commit 7fd6d98b89f3 ("i2c: i801: Allow ACPI AML access I/O
ports not reserved for SMBus"), enabling RMI on the T560 would cause
the touchpad to stop working after resuming from suspend. Now that
this issue is fixed, RMI can be enabled safely and works fine.
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Yussuf Khalil <dev@pp3345.net>
---
Originally sent this patch in August. Resending because it has a
merge conflict with v4.20-rc5.
---
drivers/input/mouse/synaptics.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 2bd5bb11c8ba..7bdf8fc2c3b5 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -171,6 +171,7 @@ static const char * const smbus_pnp_ids[] = {
"LEN0046", /* X250 */
"LEN004a", /* W541 */
"LEN005b", /* P50 */
+ "LEN005e", /* T560 */
"LEN0071", /* T480 */
"LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
"LEN0073", /* X1 Carbon G5 (Elantech) */
--
2.19.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH RESEND] Input: synaptics - enable RMI on ThinkPad T560
2018-12-08 21:44 [PATCH RESEND] Input: synaptics - enable RMI on ThinkPad T560 Yussuf Khalil
@ 2018-12-09 4:13 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2018-12-09 4:13 UTC (permalink / raw)
To: Yussuf Khalil; +Cc: benjamin.tissoires, teika, linux-input, linux-kernel
On Sat, Dec 08, 2018 at 10:44:26PM +0100, Yussuf Khalil wrote:
> Before commit 7fd6d98b89f3 ("i2c: i801: Allow ACPI AML access I/O
> ports not reserved for SMBus"), enabling RMI on the T560 would cause
> the touchpad to stop working after resuming from suspend. Now that
> this issue is fixed, RMI can be enabled safely and works fine.
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Yussuf Khalil <dev@pp3345.net>
Applied, thank you.
> ---
> Originally sent this patch in August. Resending because it has a
> merge conflict with v4.20-rc5.
> ---
> drivers/input/mouse/synaptics.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 2bd5bb11c8ba..7bdf8fc2c3b5 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -171,6 +171,7 @@ static const char * const smbus_pnp_ids[] = {
> "LEN0046", /* X250 */
> "LEN004a", /* W541 */
> "LEN005b", /* P50 */
> + "LEN005e", /* T560 */
> "LEN0071", /* T480 */
> "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
> "LEN0073", /* X1 Carbon G5 (Elantech) */
> --
> 2.19.2
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-09 4:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-08 21:44 [PATCH RESEND] Input: synaptics - enable RMI on ThinkPad T560 Yussuf Khalil
2018-12-09 4:13 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).