From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Yussuf Khalil <dev@pp3345.net>
Cc: benjamin.tissoires@redhat.com, teika@gmx.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] Input: synaptics - enable RMI on ThinkPad T560
Date: Sat, 8 Dec 2018 20:13:55 -0800 [thread overview]
Message-ID: <20181209041355.GA211094@dtor-ws> (raw)
In-Reply-To: <20181208214426.6628-1-dev@pp3345.net>
On Sat, Dec 08, 2018 at 10:44:26PM +0100, Yussuf Khalil wrote:
> Before commit 7fd6d98b89f3 ("i2c: i801: Allow ACPI AML access I/O
> ports not reserved for SMBus"), enabling RMI on the T560 would cause
> the touchpad to stop working after resuming from suspend. Now that
> this issue is fixed, RMI can be enabled safely and works fine.
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Yussuf Khalil <dev@pp3345.net>
Applied, thank you.
> ---
> Originally sent this patch in August. Resending because it has a
> merge conflict with v4.20-rc5.
> ---
> drivers/input/mouse/synaptics.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 2bd5bb11c8ba..7bdf8fc2c3b5 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -171,6 +171,7 @@ static const char * const smbus_pnp_ids[] = {
> "LEN0046", /* X250 */
> "LEN004a", /* W541 */
> "LEN005b", /* P50 */
> + "LEN005e", /* T560 */
> "LEN0071", /* T480 */
> "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
> "LEN0073", /* X1 Carbon G5 (Elantech) */
> --
> 2.19.2
>
--
Dmitry
prev parent reply other threads:[~2018-12-09 4:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-08 21:44 [PATCH RESEND] Input: synaptics - enable RMI on ThinkPad T560 Yussuf Khalil
2018-12-09 4:13 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181209041355.GA211094@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dev@pp3345.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teika@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox