* [PATCH] Input: touchscreen: ad7879: Fix ERROR: foo* bar should be "foo *bar" @ 2018-12-10 15:44 Hardik Singh Rathore 2018-12-10 19:37 ` Joe Perches 2018-12-11 11:17 ` [PATCH v2] Input: touchscreen: " Hardik Singh Rathore 0 siblings, 2 replies; 6+ messages in thread From: Hardik Singh Rathore @ 2018-12-10 15:44 UTC (permalink / raw) To: dmitry.torokhov Cc: michael.hennerich, linux-input, linux-kernel, Hardik Singh Rathore Fix the coding style problem reported by checkpatch.pl. Signed-off-by: Hardik Singh Rathore <hardiksingh.k@gmail.com> --- drivers/input/touchscreen/ad7879.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c index 6bad23ee47a1..b68902c17f2e 100644 --- a/drivers/input/touchscreen/ad7879.c +++ b/drivers/input/touchscreen/ad7879.c @@ -290,7 +290,7 @@ static int ad7879_open(struct input_dev *input) return 0; } -static void ad7879_close(struct input_dev* input) +static void ad7879_close(struct input_dev *input) { struct ad7879 *ts = input_get_drvdata(input); -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Input: touchscreen: ad7879: Fix ERROR: foo* bar should be "foo *bar" 2018-12-10 15:44 [PATCH] Input: touchscreen: ad7879: Fix ERROR: foo* bar should be "foo *bar" Hardik Singh Rathore @ 2018-12-10 19:37 ` Joe Perches 2018-12-11 11:49 ` Hardiksingh Rathore 2018-12-11 11:17 ` [PATCH v2] Input: touchscreen: " Hardik Singh Rathore 1 sibling, 1 reply; 6+ messages in thread From: Joe Perches @ 2018-12-10 19:37 UTC (permalink / raw) To: Hardik Singh Rathore, dmitry.torokhov Cc: michael.hennerich, linux-input, linux-kernel On Mon, 2018-12-10 at 21:14 +0530, Hardik Singh Rathore wrote: > Fix the coding style problem reported by checkpatch.pl. While whitespace only checkpatch cleanups are generally not well accepted, why do one pointer location cleanup when you could them all: $ ./scripts/checkpatch.pl -f --types=pointer_location --fix-inplace drivers/input/touchscreen/*.[ch] $ git diff --stat -p drivers/input/touchscreen/ produces: --- drivers/input/touchscreen/ad7879.c | 2 +- drivers/input/touchscreen/ektf2127.c | 2 +- drivers/input/touchscreen/gunze.c | 4 ++-- drivers/input/touchscreen/inexio.c | 4 ++-- drivers/input/touchscreen/mtouch.c | 4 ++-- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c index 2aae880c8aa6..6fa714c587b4 100644 --- a/drivers/input/touchscreen/ad7879.c +++ b/drivers/input/touchscreen/ad7879.c @@ -289,7 +289,7 @@ static int ad7879_open(struct input_dev *input) return 0; } -static void ad7879_close(struct input_dev* input) +static void ad7879_close(struct input_dev *input) { struct ad7879 *ts = input_get_drvdata(input); diff --git a/drivers/input/touchscreen/ektf2127.c b/drivers/input/touchscreen/ektf2127.c index 0ed34ff787ce..28fa1b36f7a5 100644 --- a/drivers/input/touchscreen/ektf2127.c +++ b/drivers/input/touchscreen/ektf2127.c @@ -51,7 +51,7 @@ struct ektf2127_ts { struct touchscreen_properties prop; }; -static void ektf2127_parse_coordinates(const u8* buf, unsigned int touch_count, +static void ektf2127_parse_coordinates(const u8 *buf, unsigned int touch_count, struct input_mt_pos *touches) { int index = 0; diff --git a/drivers/input/touchscreen/gunze.c b/drivers/input/touchscreen/gunze.c index 054c2537b392..56cf1a1ea3ea 100644 --- a/drivers/input/touchscreen/gunze.c +++ b/drivers/input/touchscreen/gunze.c @@ -53,7 +53,7 @@ struct gunze { char phys[32]; }; -static void gunze_process_packet(struct gunze* gunze) +static void gunze_process_packet(struct gunze *gunze) { struct input_dev *dev = gunze->dev; @@ -72,7 +72,7 @@ static void gunze_process_packet(struct gunze* gunze) static irqreturn_t gunze_interrupt(struct serio *serio, unsigned char data, unsigned int flags) { - struct gunze* gunze = serio_get_drvdata(serio); + struct gunze *gunze = serio_get_drvdata(serio); if (data == '\r') { gunze_process_packet(gunze); diff --git a/drivers/input/touchscreen/inexio.c b/drivers/input/touchscreen/inexio.c index b9bc56233ccc..13bd0bf580a7 100644 --- a/drivers/input/touchscreen/inexio.c +++ b/drivers/input/touchscreen/inexio.c @@ -79,7 +79,7 @@ static void inexio_process_data(struct inexio *pinexio) static irqreturn_t inexio_interrupt(struct serio *serio, unsigned char data, unsigned int flags) { - struct inexio* pinexio = serio_get_drvdata(serio); + struct inexio *pinexio = serio_get_drvdata(serio); pinexio->data[pinexio->idx] = data; @@ -97,7 +97,7 @@ static irqreturn_t inexio_interrupt(struct serio *serio, static void inexio_disconnect(struct serio *serio) { - struct inexio* pinexio = serio_get_drvdata(serio); + struct inexio *pinexio = serio_get_drvdata(serio); input_get_device(pinexio->dev); input_unregister_device(pinexio->dev); diff --git a/drivers/input/touchscreen/mtouch.c b/drivers/input/touchscreen/mtouch.c index a3707fad4d1c..8278a9058640 100644 --- a/drivers/input/touchscreen/mtouch.c +++ b/drivers/input/touchscreen/mtouch.c @@ -90,7 +90,7 @@ static void mtouch_process_response(struct mtouch *mtouch) static irqreturn_t mtouch_interrupt(struct serio *serio, unsigned char data, unsigned int flags) { - struct mtouch* mtouch = serio_get_drvdata(serio); + struct mtouch *mtouch = serio_get_drvdata(serio); mtouch->data[mtouch->idx] = data; @@ -110,7 +110,7 @@ static irqreturn_t mtouch_interrupt(struct serio *serio, static void mtouch_disconnect(struct serio *serio) { - struct mtouch* mtouch = serio_get_drvdata(serio); + struct mtouch *mtouch = serio_get_drvdata(serio); input_get_device(mtouch->dev); input_unregister_device(mtouch->dev); ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Input: touchscreen: ad7879: Fix ERROR: foo* bar should be "foo *bar" 2018-12-10 19:37 ` Joe Perches @ 2018-12-11 11:49 ` Hardiksingh Rathore 0 siblings, 0 replies; 6+ messages in thread From: Hardiksingh Rathore @ 2018-12-11 11:49 UTC (permalink / raw) To: joe; +Cc: Dmitry Torokhov, michael.hennerich, linux-input, linux-kernel Hi Joe, On Tue, 11 Dec 2018 at 01:07, Joe Perches <joe@perches.com> wrote: > > On Mon, 2018-12-10 at 21:14 +0530, Hardik Singh Rathore wrote: > > Fix the coding style problem reported by checkpatch.pl. > > While whitespace only checkpatch cleanups are generally not > well accepted, why do one pointer location cleanup when you > could them all: > As suggested, I have sent the v2 patch for pointer location cleanups in all other drivers/input/touchscreen/* files. > $ ./scripts/checkpatch.pl -f --types=pointer_location --fix-inplace drivers/input/touchscreen/*.[ch] > $ git diff --stat -p drivers/input/touchscreen/ > > produces: > --- > drivers/input/touchscreen/ad7879.c | 2 +- > drivers/input/touchscreen/ektf2127.c | 2 +- > drivers/input/touchscreen/gunze.c | 4 ++-- > drivers/input/touchscreen/inexio.c | 4 ++-- > drivers/input/touchscreen/mtouch.c | 4 ++-- > 5 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c > index 2aae880c8aa6..6fa714c587b4 100644 > --- a/drivers/input/touchscreen/ad7879.c > +++ b/drivers/input/touchscreen/ad7879.c > @@ -289,7 +289,7 @@ static int ad7879_open(struct input_dev *input) > return 0; > } > > -static void ad7879_close(struct input_dev* input) > +static void ad7879_close(struct input_dev *input) > { > struct ad7879 *ts = input_get_drvdata(input); > > diff --git a/drivers/input/touchscreen/ektf2127.c b/drivers/input/touchscreen/ektf2127.c > index 0ed34ff787ce..28fa1b36f7a5 100644 > --- a/drivers/input/touchscreen/ektf2127.c > +++ b/drivers/input/touchscreen/ektf2127.c > @@ -51,7 +51,7 @@ struct ektf2127_ts { > struct touchscreen_properties prop; > }; > > -static void ektf2127_parse_coordinates(const u8* buf, unsigned int touch_count, > +static void ektf2127_parse_coordinates(const u8 *buf, unsigned int touch_count, > struct input_mt_pos *touches) > { > int index = 0; > diff --git a/drivers/input/touchscreen/gunze.c b/drivers/input/touchscreen/gunze.c > index 054c2537b392..56cf1a1ea3ea 100644 > --- a/drivers/input/touchscreen/gunze.c > +++ b/drivers/input/touchscreen/gunze.c > @@ -53,7 +53,7 @@ struct gunze { > char phys[32]; > }; > > -static void gunze_process_packet(struct gunze* gunze) > +static void gunze_process_packet(struct gunze *gunze) > { > struct input_dev *dev = gunze->dev; > > @@ -72,7 +72,7 @@ static void gunze_process_packet(struct gunze* gunze) > static irqreturn_t gunze_interrupt(struct serio *serio, > unsigned char data, unsigned int flags) > { > - struct gunze* gunze = serio_get_drvdata(serio); > + struct gunze *gunze = serio_get_drvdata(serio); > > if (data == '\r') { > gunze_process_packet(gunze); > diff --git a/drivers/input/touchscreen/inexio.c b/drivers/input/touchscreen/inexio.c > index b9bc56233ccc..13bd0bf580a7 100644 > --- a/drivers/input/touchscreen/inexio.c > +++ b/drivers/input/touchscreen/inexio.c > @@ -79,7 +79,7 @@ static void inexio_process_data(struct inexio *pinexio) > static irqreturn_t inexio_interrupt(struct serio *serio, > unsigned char data, unsigned int flags) > { > - struct inexio* pinexio = serio_get_drvdata(serio); > + struct inexio *pinexio = serio_get_drvdata(serio); > > pinexio->data[pinexio->idx] = data; > > @@ -97,7 +97,7 @@ static irqreturn_t inexio_interrupt(struct serio *serio, > > static void inexio_disconnect(struct serio *serio) > { > - struct inexio* pinexio = serio_get_drvdata(serio); > + struct inexio *pinexio = serio_get_drvdata(serio); > > input_get_device(pinexio->dev); > input_unregister_device(pinexio->dev); > diff --git a/drivers/input/touchscreen/mtouch.c b/drivers/input/touchscreen/mtouch.c > index a3707fad4d1c..8278a9058640 100644 > --- a/drivers/input/touchscreen/mtouch.c > +++ b/drivers/input/touchscreen/mtouch.c > @@ -90,7 +90,7 @@ static void mtouch_process_response(struct mtouch *mtouch) > static irqreturn_t mtouch_interrupt(struct serio *serio, > unsigned char data, unsigned int flags) > { > - struct mtouch* mtouch = serio_get_drvdata(serio); > + struct mtouch *mtouch = serio_get_drvdata(serio); > > mtouch->data[mtouch->idx] = data; > > @@ -110,7 +110,7 @@ static irqreturn_t mtouch_interrupt(struct serio *serio, > > static void mtouch_disconnect(struct serio *serio) > { > - struct mtouch* mtouch = serio_get_drvdata(serio); > + struct mtouch *mtouch = serio_get_drvdata(serio); > > input_get_device(mtouch->dev); > input_unregister_device(mtouch->dev); > > -- Thanks, Hardik ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] Input: touchscreen: Fix ERROR: foo* bar should be "foo *bar" 2018-12-10 15:44 [PATCH] Input: touchscreen: ad7879: Fix ERROR: foo* bar should be "foo *bar" Hardik Singh Rathore 2018-12-10 19:37 ` Joe Perches @ 2018-12-11 11:17 ` Hardik Singh Rathore 2018-12-11 13:03 ` [PATCH v3] Input: touchscreen: Fix coding style issue Hardik Singh Rathore 1 sibling, 1 reply; 6+ messages in thread From: Hardik Singh Rathore @ 2018-12-11 11:17 UTC (permalink / raw) To: dmitry.torokhov; +Cc: linux-input, linux-kernel, joe, Hardik Singh Rathore This patch fixes the coding style problem reported by checkpatch.pl. Signed-off-by: Hardik Singh Rathore <hardiksingh.k@gmail.com> --- v2: - fix the pointer location style problem in drivers/input/touchscreen/* files leftover in previous patch. drivers/input/touchscreen/ektf2127.c | 2 +- drivers/input/touchscreen/gunze.c | 4 ++-- drivers/input/touchscreen/inexio.c | 4 ++-- drivers/input/touchscreen/mtouch.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/ektf2127.c b/drivers/input/touchscreen/ektf2127.c index 0ed34ff787ce..28fa1b36f7a5 100644 --- a/drivers/input/touchscreen/ektf2127.c +++ b/drivers/input/touchscreen/ektf2127.c @@ -51,7 +51,7 @@ struct ektf2127_ts { struct touchscreen_properties prop; }; -static void ektf2127_parse_coordinates(const u8* buf, unsigned int touch_count, +static void ektf2127_parse_coordinates(const u8 *buf, unsigned int touch_count, struct input_mt_pos *touches) { int index = 0; diff --git a/drivers/input/touchscreen/gunze.c b/drivers/input/touchscreen/gunze.c index 054c2537b392..56cf1a1ea3ea 100644 --- a/drivers/input/touchscreen/gunze.c +++ b/drivers/input/touchscreen/gunze.c @@ -53,7 +53,7 @@ struct gunze { char phys[32]; }; -static void gunze_process_packet(struct gunze* gunze) +static void gunze_process_packet(struct gunze *gunze) { struct input_dev *dev = gunze->dev; @@ -72,7 +72,7 @@ static void gunze_process_packet(struct gunze* gunze) static irqreturn_t gunze_interrupt(struct serio *serio, unsigned char data, unsigned int flags) { - struct gunze* gunze = serio_get_drvdata(serio); + struct gunze *gunze = serio_get_drvdata(serio); if (data == '\r') { gunze_process_packet(gunze); diff --git a/drivers/input/touchscreen/inexio.c b/drivers/input/touchscreen/inexio.c index b9bc56233ccc..13bd0bf580a7 100644 --- a/drivers/input/touchscreen/inexio.c +++ b/drivers/input/touchscreen/inexio.c @@ -79,7 +79,7 @@ static void inexio_process_data(struct inexio *pinexio) static irqreturn_t inexio_interrupt(struct serio *serio, unsigned char data, unsigned int flags) { - struct inexio* pinexio = serio_get_drvdata(serio); + struct inexio *pinexio = serio_get_drvdata(serio); pinexio->data[pinexio->idx] = data; @@ -97,7 +97,7 @@ static irqreturn_t inexio_interrupt(struct serio *serio, static void inexio_disconnect(struct serio *serio) { - struct inexio* pinexio = serio_get_drvdata(serio); + struct inexio *pinexio = serio_get_drvdata(serio); input_get_device(pinexio->dev); input_unregister_device(pinexio->dev); diff --git a/drivers/input/touchscreen/mtouch.c b/drivers/input/touchscreen/mtouch.c index a3707fad4d1c..8278a9058640 100644 --- a/drivers/input/touchscreen/mtouch.c +++ b/drivers/input/touchscreen/mtouch.c @@ -90,7 +90,7 @@ static void mtouch_process_response(struct mtouch *mtouch) static irqreturn_t mtouch_interrupt(struct serio *serio, unsigned char data, unsigned int flags) { - struct mtouch* mtouch = serio_get_drvdata(serio); + struct mtouch *mtouch = serio_get_drvdata(serio); mtouch->data[mtouch->idx] = data; @@ -110,7 +110,7 @@ static irqreturn_t mtouch_interrupt(struct serio *serio, static void mtouch_disconnect(struct serio *serio) { - struct mtouch* mtouch = serio_get_drvdata(serio); + struct mtouch *mtouch = serio_get_drvdata(serio); input_get_device(mtouch->dev); input_unregister_device(mtouch->dev); -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3] Input: touchscreen: Fix coding style issue 2018-12-11 11:17 ` [PATCH v2] Input: touchscreen: " Hardik Singh Rathore @ 2018-12-11 13:03 ` Hardik Singh Rathore 2018-12-21 9:07 ` Dmitry Torokhov 0 siblings, 1 reply; 6+ messages in thread From: Hardik Singh Rathore @ 2018-12-11 13:03 UTC (permalink / raw) To: dmitry.torokhov Cc: michael.hennerich, linux-input, linux-kernel, joe, Hardik Singh Rathore This patch fixes the coding style problem reported by checkpatch.pl as below: ERROR: foo* bar should be "foo *bar" Signed-off-by: Hardik Singh Rathore <hardiksingh.k@gmail.com> --- v3: - v2 was depends on v1 so it didn't solve the issue. drivers/input/touchscreen/ad7879.c | 2 +- drivers/input/touchscreen/ektf2127.c | 2 +- drivers/input/touchscreen/gunze.c | 4 ++-- drivers/input/touchscreen/inexio.c | 4 ++-- drivers/input/touchscreen/mtouch.c | 4 ++-- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c index 6bad23ee47a1..b68902c17f2e 100644 --- a/drivers/input/touchscreen/ad7879.c +++ b/drivers/input/touchscreen/ad7879.c @@ -290,7 +290,7 @@ static int ad7879_open(struct input_dev *input) return 0; } -static void ad7879_close(struct input_dev* input) +static void ad7879_close(struct input_dev *input) { struct ad7879 *ts = input_get_drvdata(input); diff --git a/drivers/input/touchscreen/ektf2127.c b/drivers/input/touchscreen/ektf2127.c index 0ed34ff787ce..28fa1b36f7a5 100644 --- a/drivers/input/touchscreen/ektf2127.c +++ b/drivers/input/touchscreen/ektf2127.c @@ -51,7 +51,7 @@ struct ektf2127_ts { struct touchscreen_properties prop; }; -static void ektf2127_parse_coordinates(const u8* buf, unsigned int touch_count, +static void ektf2127_parse_coordinates(const u8 *buf, unsigned int touch_count, struct input_mt_pos *touches) { int index = 0; diff --git a/drivers/input/touchscreen/gunze.c b/drivers/input/touchscreen/gunze.c index 054c2537b392..56cf1a1ea3ea 100644 --- a/drivers/input/touchscreen/gunze.c +++ b/drivers/input/touchscreen/gunze.c @@ -53,7 +53,7 @@ struct gunze { char phys[32]; }; -static void gunze_process_packet(struct gunze* gunze) +static void gunze_process_packet(struct gunze *gunze) { struct input_dev *dev = gunze->dev; @@ -72,7 +72,7 @@ static void gunze_process_packet(struct gunze* gunze) static irqreturn_t gunze_interrupt(struct serio *serio, unsigned char data, unsigned int flags) { - struct gunze* gunze = serio_get_drvdata(serio); + struct gunze *gunze = serio_get_drvdata(serio); if (data == '\r') { gunze_process_packet(gunze); diff --git a/drivers/input/touchscreen/inexio.c b/drivers/input/touchscreen/inexio.c index b9bc56233ccc..13bd0bf580a7 100644 --- a/drivers/input/touchscreen/inexio.c +++ b/drivers/input/touchscreen/inexio.c @@ -79,7 +79,7 @@ static void inexio_process_data(struct inexio *pinexio) static irqreturn_t inexio_interrupt(struct serio *serio, unsigned char data, unsigned int flags) { - struct inexio* pinexio = serio_get_drvdata(serio); + struct inexio *pinexio = serio_get_drvdata(serio); pinexio->data[pinexio->idx] = data; @@ -97,7 +97,7 @@ static irqreturn_t inexio_interrupt(struct serio *serio, static void inexio_disconnect(struct serio *serio) { - struct inexio* pinexio = serio_get_drvdata(serio); + struct inexio *pinexio = serio_get_drvdata(serio); input_get_device(pinexio->dev); input_unregister_device(pinexio->dev); diff --git a/drivers/input/touchscreen/mtouch.c b/drivers/input/touchscreen/mtouch.c index a3707fad4d1c..8278a9058640 100644 --- a/drivers/input/touchscreen/mtouch.c +++ b/drivers/input/touchscreen/mtouch.c @@ -90,7 +90,7 @@ static void mtouch_process_response(struct mtouch *mtouch) static irqreturn_t mtouch_interrupt(struct serio *serio, unsigned char data, unsigned int flags) { - struct mtouch* mtouch = serio_get_drvdata(serio); + struct mtouch *mtouch = serio_get_drvdata(serio); mtouch->data[mtouch->idx] = data; @@ -110,7 +110,7 @@ static irqreturn_t mtouch_interrupt(struct serio *serio, static void mtouch_disconnect(struct serio *serio) { - struct mtouch* mtouch = serio_get_drvdata(serio); + struct mtouch *mtouch = serio_get_drvdata(serio); input_get_device(mtouch->dev); input_unregister_device(mtouch->dev); -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] Input: touchscreen: Fix coding style issue 2018-12-11 13:03 ` [PATCH v3] Input: touchscreen: Fix coding style issue Hardik Singh Rathore @ 2018-12-21 9:07 ` Dmitry Torokhov 0 siblings, 0 replies; 6+ messages in thread From: Dmitry Torokhov @ 2018-12-21 9:07 UTC (permalink / raw) To: Hardik Singh Rathore; +Cc: michael.hennerich, linux-input, linux-kernel, joe On Tue, Dec 11, 2018 at 06:33:32PM +0530, Hardik Singh Rathore wrote: > This patch fixes the coding style problem reported > by checkpatch.pl as below: > > ERROR: foo* bar should be "foo *bar" > > Signed-off-by: Hardik Singh Rathore <hardiksingh.k@gmail.com> Applied, thank you. > --- > v3: > - v2 was depends on v1 so it didn't solve the issue. > > drivers/input/touchscreen/ad7879.c | 2 +- > drivers/input/touchscreen/ektf2127.c | 2 +- > drivers/input/touchscreen/gunze.c | 4 ++-- > drivers/input/touchscreen/inexio.c | 4 ++-- > drivers/input/touchscreen/mtouch.c | 4 ++-- > 5 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c > index 6bad23ee47a1..b68902c17f2e 100644 > --- a/drivers/input/touchscreen/ad7879.c > +++ b/drivers/input/touchscreen/ad7879.c > @@ -290,7 +290,7 @@ static int ad7879_open(struct input_dev *input) > return 0; > } > > -static void ad7879_close(struct input_dev* input) > +static void ad7879_close(struct input_dev *input) > { > struct ad7879 *ts = input_get_drvdata(input); > > diff --git a/drivers/input/touchscreen/ektf2127.c b/drivers/input/touchscreen/ektf2127.c > index 0ed34ff787ce..28fa1b36f7a5 100644 > --- a/drivers/input/touchscreen/ektf2127.c > +++ b/drivers/input/touchscreen/ektf2127.c > @@ -51,7 +51,7 @@ struct ektf2127_ts { > struct touchscreen_properties prop; > }; > > -static void ektf2127_parse_coordinates(const u8* buf, unsigned int touch_count, > +static void ektf2127_parse_coordinates(const u8 *buf, unsigned int touch_count, > struct input_mt_pos *touches) > { > int index = 0; > diff --git a/drivers/input/touchscreen/gunze.c b/drivers/input/touchscreen/gunze.c > index 054c2537b392..56cf1a1ea3ea 100644 > --- a/drivers/input/touchscreen/gunze.c > +++ b/drivers/input/touchscreen/gunze.c > @@ -53,7 +53,7 @@ struct gunze { > char phys[32]; > }; > > -static void gunze_process_packet(struct gunze* gunze) > +static void gunze_process_packet(struct gunze *gunze) > { > struct input_dev *dev = gunze->dev; > > @@ -72,7 +72,7 @@ static void gunze_process_packet(struct gunze* gunze) > static irqreturn_t gunze_interrupt(struct serio *serio, > unsigned char data, unsigned int flags) > { > - struct gunze* gunze = serio_get_drvdata(serio); > + struct gunze *gunze = serio_get_drvdata(serio); > > if (data == '\r') { > gunze_process_packet(gunze); > diff --git a/drivers/input/touchscreen/inexio.c b/drivers/input/touchscreen/inexio.c > index b9bc56233ccc..13bd0bf580a7 100644 > --- a/drivers/input/touchscreen/inexio.c > +++ b/drivers/input/touchscreen/inexio.c > @@ -79,7 +79,7 @@ static void inexio_process_data(struct inexio *pinexio) > static irqreturn_t inexio_interrupt(struct serio *serio, > unsigned char data, unsigned int flags) > { > - struct inexio* pinexio = serio_get_drvdata(serio); > + struct inexio *pinexio = serio_get_drvdata(serio); > > pinexio->data[pinexio->idx] = data; > > @@ -97,7 +97,7 @@ static irqreturn_t inexio_interrupt(struct serio *serio, > > static void inexio_disconnect(struct serio *serio) > { > - struct inexio* pinexio = serio_get_drvdata(serio); > + struct inexio *pinexio = serio_get_drvdata(serio); > > input_get_device(pinexio->dev); > input_unregister_device(pinexio->dev); > diff --git a/drivers/input/touchscreen/mtouch.c b/drivers/input/touchscreen/mtouch.c > index a3707fad4d1c..8278a9058640 100644 > --- a/drivers/input/touchscreen/mtouch.c > +++ b/drivers/input/touchscreen/mtouch.c > @@ -90,7 +90,7 @@ static void mtouch_process_response(struct mtouch *mtouch) > static irqreturn_t mtouch_interrupt(struct serio *serio, > unsigned char data, unsigned int flags) > { > - struct mtouch* mtouch = serio_get_drvdata(serio); > + struct mtouch *mtouch = serio_get_drvdata(serio); > > mtouch->data[mtouch->idx] = data; > > @@ -110,7 +110,7 @@ static irqreturn_t mtouch_interrupt(struct serio *serio, > > static void mtouch_disconnect(struct serio *serio) > { > - struct mtouch* mtouch = serio_get_drvdata(serio); > + struct mtouch *mtouch = serio_get_drvdata(serio); > > input_get_device(mtouch->dev); > input_unregister_device(mtouch->dev); > -- > 2.17.1 > -- Dmitry ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-21 9:07 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-12-10 15:44 [PATCH] Input: touchscreen: ad7879: Fix ERROR: foo* bar should be "foo *bar" Hardik Singh Rathore 2018-12-10 19:37 ` Joe Perches 2018-12-11 11:49 ` Hardiksingh Rathore 2018-12-11 11:17 ` [PATCH v2] Input: touchscreen: " Hardik Singh Rathore 2018-12-11 13:03 ` [PATCH v3] Input: touchscreen: Fix coding style issue Hardik Singh Rathore 2018-12-21 9:07 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).