From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kangjie Lu Subject: [PATCH v2] touchscreen: elants: fix a missing check of return values Date: Mon, 24 Dec 2018 22:36:13 -0600 Message-ID: <20181225043616.66032-1-kjlu@umn.edu> Return-path: Sender: linux-kernel-owner@vger.kernel.org To: kjlu@umn.edu Cc: pakki001@umn.edu, Dmitry Torokhov , Greg Kroah-Hartman , Stephen Boyd , Joe Perches , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org elants_i2c_send() may fail, let's check its return values. The fix does the check and reports an error message upon the failure. Signed-off-by: Kangjie Lu --- drivers/input/touchscreen/elants_i2c.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c index f2cb23121833..8ccba4ccee37 100644 --- a/drivers/input/touchscreen/elants_i2c.c +++ b/drivers/input/touchscreen/elants_i2c.c @@ -245,8 +245,22 @@ static int elants_i2c_calibrate(struct elants_data *ts) ts->state = ELAN_WAIT_RECALIBRATION; reinit_completion(&ts->cmd_done); - elants_i2c_send(client, w_flashkey, sizeof(w_flashkey)); - elants_i2c_send(client, rek, sizeof(rek)); + error = elants_i2c_send(client, w_flashkey, sizeof(w_flashkey)); + if (error) { + dev_err(&client->dev, + "error in sending the w_flashkey command for calibration: %d\n", + error); + enable_irq(client->irq); + return error; + } + error = elants_i2c_send(client, rek, sizeof(rek)); + if (error) { + dev_err(&client->dev, + "error in sending the rek command for calibration: %d\n", + error); + enable_irq(client->irq); + return error; + } enable_irq(client->irq); -- 2.17.2 (Apple Git-113)