From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alex Gonzalez <alex.gonzalez@digi.com>
Cc: hadess@hadess.net, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: goodix - decouple irq and reset lines
Date: Sat, 5 Jan 2019 22:51:47 +0000 [thread overview]
Message-ID: <20190105225147.le5fgpnvq7sctxe5@penguin> (raw)
In-Reply-To: <1546617648-23445-2-git-send-email-alex.gonzalez@digi.com>
Hi Alex,
On Fri, Jan 04, 2019 at 05:00:48PM +0100, Alex Gonzalez wrote:
> The Goodix touch controller allows the use of two optional GPIOs (RESET
> and INT) to reset the touch controller, select the I2C address of the
> device and exit the device from sleep mode.
>
> The current implementation requires both GPIOs to be provided, however,
> it is possible to provide only the INT line and not to have the RESET line
> available but pulled-up.
>
> Designs that only provide the INT line are able to operate the touch on
> the default I2C address but will not be able to reset the touch via
> software or place the device in sleep mode.
I do not have a datasheet for the device, so I am not sure if reset line
is actually needed to put the device into sleep mode. As far as I can
see from the code we suspend it by pulsing INT line and then sending a
command to the controller, and resuming by pulsing the INT line again.
So it sounds to me INT only designs _could_ place device in sleep mode.
As far as the patch goes, if you do not need to execute reset or put
device into low power mode, you do not need to specify any of the GPIOs
as GPIO resources. Simply specify the INT GPIO as your interrupt source
(GpioInt() in ACPI world or "interrupts = <&gpio NNN
IRQF_TRIGGER_WHATEVER>" in DT world and be done with it.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-01-05 22:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 16:00 [PATCH] Input: goodix - decouple irq and reset lines Alex Gonzalez
2019-01-04 16:00 ` Alex Gonzalez
2019-01-04 22:31 ` Andreas Gohr
2019-01-05 22:51 ` Dmitry Torokhov [this message]
2019-01-07 10:13 ` Gonzalez, Alex
2019-01-07 15:56 ` Bastien Nocera
2019-01-07 16:01 ` Bastien Nocera
2019-01-07 16:44 ` Gonzalez, Alex
2019-01-07 16:42 ` Gonzalez, Alex
2019-01-07 18:56 ` Dmitry Torokhov
2019-01-08 17:20 ` Gonzalez, Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190105225147.le5fgpnvq7sctxe5@penguin \
--to=dmitry.torokhov@gmail.com \
--cc=alex.gonzalez@digi.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).