From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/7] Input: document meanings of KEY_SCREEN and KEY_ZOOM Date: Wed, 23 Jan 2019 14:07:35 -0800 Message-ID: <20190123220735.GE179701@dtor-ws> References: <20190118233037.87318-1-dmitry.torokhov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Mauro Carvalho Chehab Cc: Jiri Kosina , "open list:HID CORE LAYER" , lkml , linux-media@vger.kernel.org, Benjamin Tissoires List-Id: linux-input@vger.kernel.org On Mon, Jan 21, 2019 at 11:41:32AM +0100, Benjamin Tissoires wrote: > On Mon, Jan 21, 2019 at 11:11 AM Jiri Kosina wrote: > > > > On Fri, 18 Jan 2019, Dmitry Torokhov wrote: > > > > > It is hard to say what KEY_SCREEN and KEY_ZOOM mean, but historically DVB > > > folks have used them to indicate switch to full screen mode. Later, they > > > converged on using KEY_ZOOM to switch into full screen mode and KEY)SCREEN > > > to control aspect ratio (see Documentation/media/uapi/rc/rc-tables.rst). > > > > > > Let's commit to these uses, and define: > > > > > > - KEY_FULL_SCREEN (and make KEY_ZOOM its alias) > > > - KEY_ASPECT_RATIO (and make KEY_SCREEN its alias) > > > > > > Signed-off-by: Dmitry Torokhov > > > --- > > > > > > Please let me know how we want merge this. Some of patches can be applied > > > independently and I tried marking them as such, but some require new key > > > names from input.h > > > > Acked-by: Jiri Kosina > > Acked-by: Benjamin Tissoires Mauro, any objections on pushing the media doc patch through my tree? Thanks. -- Dmitry