From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Rob Herring <robh@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
TOUCHSCREEN)..." <linux-input@vger.kernel.org>
Subject: Re: [PATCH] Input: gpio-keys - Add shutdown callback
Date: Tue, 5 Feb 2019 16:45:29 -0800 [thread overview]
Message-ID: <20190206004529.GC19151@dtor-ws> (raw)
In-Reply-To: <65d6350f-2cd8-c183-6d8b-dbb11ae31819@gmail.com>
On Tue, Feb 05, 2019 at 02:02:49PM -0800, Florian Fainelli wrote:
> On 2/1/19 11:24 AM, Florian Fainelli wrote:
> > On some platforms (e.g.: ARCH_BRCMSTB) it is possible to enter
> > "poweroff" while leaving some wake-up sources enabled such as key
> > presses in order to allow for the system to wake-up.
> >
> > Wire up a .shutdown() callback which calls into the existing
> > gpio_keys_suspend() since the logic is essentially the same.
> >
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > ---
> > drivers/input/keyboard/gpio_keys.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
>
> Any feedback on this?
OK, I'll take it. Hopefully it won't affect existing systems as the
change is unconditional.
Thanks.
--
Dmitry
prev parent reply other threads:[~2019-02-06 0:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 19:24 [PATCH] Input: gpio-keys - Add shutdown callback Florian Fainelli
2019-02-05 22:02 ` Florian Fainelli
2019-02-06 0:45 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206004529.GC19151@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=f.fainelli@gmail.com \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).