From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Martin Kepplinger <martin.kepplinger@ginzinger.com>
Cc: Martin Kepplinger <martink@posteo.de>,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: st1232 - switch to gpiod API
Date: Fri, 8 Feb 2019 00:05:55 -0800 [thread overview]
Message-ID: <20190208080555.GD31622@dtor-ws> (raw)
In-Reply-To: <83a86244-f40b-44b1-d7be-1fcbeb4c359e@ginzinger.com>
Hi Martin,
On Tue, Feb 05, 2019 at 11:20:16AM +0100, Martin Kepplinger wrote:
> On 29.01.19 11:23, Martin Kepplinger wrote:
> > From: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> >
> > Use devm_gpiod_get_optional() and gpiod_set_value_cansleep() instead
> > of the old API. The st1232_ts_power() now passes on the inverted "poweron"
> > value to reflect the correct logical value.
> >
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> > ---
> >
> > Tested and works. thanks for your help Dmitry,
> >
>
> is this what you had in mind? any problems or questions?
Yes, that is what I wanted, with one exception:
> > + ts->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset",
> > + GPIOD_OUT_HIGH);
This breaks compatibility with old DTSes, please try changing to:
devm_gpiod_get_optional(&client->dev, NULL, GPIOD_OUT_HIGH);
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-02-08 8:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 10:23 [PATCH 1/2] dt-bindings: input: sitronix-st1232: document optional reset-gpios property Martin Kepplinger
2019-01-29 10:23 ` [PATCH 2/2] Input: st1232 - switch to gpiod API Martin Kepplinger
2019-02-05 10:20 ` Martin Kepplinger
2019-02-08 8:05 ` Dmitry Torokhov [this message]
2019-02-25 14:43 ` [PATCH 1/2] dt-bindings: input: sitronix-st1232: document optional reset-gpios property Rob Herring
2019-02-26 6:18 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208080555.GD31622@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.kepplinger@ginzinger.com \
--cc=martink@posteo.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).