From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2 2/2] input: misc: pwm-vibra: Stop regulator after disabling pwm, not before Date: Sat, 9 Feb 2019 09:13:10 -0800 Message-ID: <20190209171310.GF197782@dtor-ws> References: <20190124202732.14723-1-pawel.mikolaj.chmiel@gmail.com> <20190124202732.14723-2-pawel.mikolaj.chmiel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190124202732.14723-2-pawel.mikolaj.chmiel@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: =?utf-8?B?UGF3ZcWC?= Chmiel Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org On Thu, Jan 24, 2019 at 09:27:32PM +0100, Paweł Chmiel wrote: > This patch fixes order of disable calls in pwm_vibrator_stop. > Currently when starting device, we first enable vcc regulator and then > setup and enable pwm. When stopping, we should do this in oposite order, > so first disable pwm and then disable regulator. > Previously order was the same as in start. > > Signed-off-by: Paweł Chmiel Applied, thank you. > --- > drivers/input/misc/pwm-vibra.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/misc/pwm-vibra.c b/drivers/input/misc/pwm-vibra.c > index 9df87431d7d4..dbb6d9e1b947 100644 > --- a/drivers/input/misc/pwm-vibra.c > +++ b/drivers/input/misc/pwm-vibra.c > @@ -80,14 +80,14 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator) > > static void pwm_vibrator_stop(struct pwm_vibrator *vibrator) > { > + if (vibrator->pwm_dir) > + pwm_disable(vibrator->pwm_dir); > + pwm_disable(vibrator->pwm); > + > if (vibrator->vcc_on) { > regulator_disable(vibrator->vcc); > vibrator->vcc_on = false; > } > - > - if (vibrator->pwm_dir) > - pwm_disable(vibrator->pwm_dir); > - pwm_disable(vibrator->pwm); > } > > static void pwm_vibrator_play_work(struct work_struct *work) > -- > 2.17.1 > -- Dmitry