* [PATCH] Input: st1232 - include gpio/consumer.h header for gpiod_set_value_cansleep()
[not found] <201902131841.xHSZ8Cvm%fengguang.wu@intel.com>
@ 2019-02-13 11:19 ` Martin Kepplinger
2019-02-17 5:35 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Martin Kepplinger @ 2019-02-13 11:19 UTC (permalink / raw)
To: dmitry.torokhov, kuninori.morimoto.gx, linux-input
Cc: linux-kernel, Martin Kepplinger
gpiod_set_value_cansleep() needs it's declaration in the corresponding
header. This fixes build errors like
drivers/input/touchscreen/st1232.c: In function 'st1232_ts_power':
>> drivers/input/touchscreen/st1232.c:146:3: error: implicit declaration of
function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'?
[-Werror=implicit-function-declaration]
gpiod_set_value_cansleep(ts->reset_gpio, !poweron);
^~~~~~~~~~~~~~~~~~~~~~~~
gpio_set_value_cansleep
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
drivers/input/touchscreen/st1232.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/st1232.c b/drivers/input/touchscreen/st1232.c
index 1fbc0847416b..f4b7a4f1c366 100644
--- a/drivers/input/touchscreen/st1232.c
+++ b/drivers/input/touchscreen/st1232.c
@@ -18,6 +18,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/pm_qos.h>
#include <linux/slab.h>
#include <linux/types.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: st1232 - include gpio/consumer.h header for gpiod_set_value_cansleep()
2019-02-13 11:19 ` [PATCH] Input: st1232 - include gpio/consumer.h header for gpiod_set_value_cansleep() Martin Kepplinger
@ 2019-02-17 5:35 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2019-02-17 5:35 UTC (permalink / raw)
To: Martin Kepplinger; +Cc: kuninori.morimoto.gx, linux-input, linux-kernel
On Wed, Feb 13, 2019 at 12:19:58PM +0100, Martin Kepplinger wrote:
> gpiod_set_value_cansleep() needs it's declaration in the corresponding
> header. This fixes build errors like
>
> drivers/input/touchscreen/st1232.c: In function 'st1232_ts_power':
> >> drivers/input/touchscreen/st1232.c:146:3: error: implicit declaration of
> function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'?
> [-Werror=implicit-function-declaration]
> gpiod_set_value_cansleep(ts->reset_gpio, !poweron);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> gpio_set_value_cansleep
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
Thanks Martin, I'll fold it into the original patch introducing gpiod so
we keep bisectability.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-17 5:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201902131841.xHSZ8Cvm%fengguang.wu@intel.com>
2019-02-13 11:19 ` [PATCH] Input: st1232 - include gpio/consumer.h header for gpiod_set_value_cansleep() Martin Kepplinger
2019-02-17 5:35 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).