From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Rodrigo Rivas Costa <rodrigorivascosta@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
Peter Hutterer <peter.hutterer@who-t.net>,
"Paul E. McKenney" <paulmck@linux.ibm.com>,
Martin Kepplinger <martink@posteo.de>,
"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
TOUCHSCREEN)" <linux-input@vger.kernel.org>
Subject: Re: [PATCH] Input: uinput - Allow uinput_request to be interrupted
Date: Mon, 18 Feb 2019 12:15:44 -0800 [thread overview]
Message-ID: <20190218201544.GA192977@dtor-ws> (raw)
In-Reply-To: <20190218142110.GA23087@casa>
On Mon, Feb 18, 2019 at 03:21:10PM +0100, Rodrigo Rivas Costa wrote:
> On Sun, Feb 17, 2019 at 09:42:52PM -0300, Marcos Paulo de Souza wrote:
> > - if (!wait_for_completion_timeout(&request->done, 30 * HZ)) {
> > + if (!wait_for_completion_interruptible_timeout(&request->done,
> > + 30 * HZ)) {
> > retval = -ETIMEDOUT;
> > goto out;
> > }
>
> Now this function can succeed or fail because of ETIMEDOUT or an
> interrupt. I think you should return -EINTR or maybe -ESYSRESTART if
> interrupted.
Rodrigo, you are right. Marcos, could you please send updated patch that
returns different error code for timeout vs interrupt condition?
I dropped the patch for now.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-02-18 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190218004305.339758-1-marcos.souza.org@gmail.com>
2019-02-18 14:21 ` [PATCH] Input: uinput - Allow uinput_request to be interrupted Rodrigo Rivas Costa
2019-02-18 20:15 ` Dmitry Torokhov [this message]
2019-02-21 11:11 ` Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218201544.GA192977@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
--cc=martink@posteo.de \
--cc=paulmck@linux.ibm.com \
--cc=peter.hutterer@who-t.net \
--cc=rodrigorivascosta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).