From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH next 09/25] input: keyboard: Use dev_get_drvdata()
Date: Tue, 23 Apr 2019 08:44:18 +0000 [thread overview]
Message-ID: <20190423084418.sekqt5jeiqctvofe@penguin> (raw)
In-Reply-To: <20190423075020.173734-10-wangkefeng.wang@huawei.com>
Hi Kefeng,
On Tue, Apr 23, 2019 at 03:50:04PM +0800, Kefeng Wang wrote:
> Using dev_get_drvdata directly.
This assumes that generic device's driver data is exactly the same as platform
device's driver data. This is true today, but does not have to be true
tomorrow.
What is the benefit of violating the layering and accessing "parent"
object's abstraction directly? Performance impact must be negligible...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-04-23 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190423075020.173734-1-wangkefeng.wang@huawei.com>
2019-04-23 7:50 ` [PATCH next 09/25] input: keyboard: Use dev_get_drvdata() Kefeng Wang
2019-04-23 8:44 ` Dmitry Torokhov [this message]
2019-04-23 7:50 ` [PATCH next 10/25] input: misc: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 11/25] input: mouse: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 12/25] input: touchscreen: " Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423084418.sekqt5jeiqctvofe@penguin \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox