From: Rob Herring <robh@kernel.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
mark.rutland@arm.com, Lee Jones <lee.jones@linaro.org>,
bjorn.andersson@linaro.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
agross@kernel.org, David Brown <david.brown@linaro.org>,
Jiri Kosina <jikos@kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: input: add Elan 400 combo keyboard/touchpad over i2c
Date: Fri, 26 Apr 2019 17:49:08 -0500 [thread overview]
Message-ID: <20190426224908.GA30389@bogus> (raw)
In-Reply-To: <CAO-hwJJ_BRRHL44yaZ=d_K-9iq1cyONn0rR+VW3ukW1M2Ma0ug@mail.gmail.com>
On Thu, Apr 18, 2019 at 11:35:42AM +0200, Benjamin Tissoires wrote:
> On Mon, Apr 15, 2019 at 6:11 PM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote:
> >
> > The Elan 400 combo keyboard/touchpad over i2c device is a distinct device
> > from the Elan 400 standalone touchpad device. The combo device has been
> > found in the Lenovo Miix 630 and HP Envy x2 laptops.
> >
> > Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> > ---
>
> With my comments in 2/3, I wonder if you need this patch at all then.
I don't really follow the discussion in 2/3, but you should still have
specific compatibles even if right now you don't need them.
>
> Cheers,
> Benjamin
>
> > .../devicetree/bindings/input/elan,combo400-i2c.txt | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/input/elan,combo400-i2c.txt
> >
> > diff --git a/Documentation/devicetree/bindings/input/elan,combo400-i2c.txt b/Documentation/devicetree/bindings/input/elan,combo400-i2c.txt
> > new file mode 100644
> > index 000000000000..fb700a29148d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/elan,combo400-i2c.txt
> > @@ -0,0 +1,11 @@
> > +Elantech 0400 I2C combination Keyboard/Touchpad
> > +
> > +This binding describes an Elan device with pid 0x0400, that is a combination
> > +keyboard + touchpad device. This binding does not cover an Elan device with
> > +pid 0x0400 that is solely a standalone touchpad device.
> > +
> > +Required properties:
> > +- compatible: should be "elan,combo400-i2c"
> > +
> > +This binding is compatible with the HID over I2C binding, which is specified
> > +in hid-over-i2c.txt in this directory.
Separate is fine, but we've been adding compatibles to hid-over-i2c.txt.
Rob
next prev parent reply other threads:[~2019-04-26 22:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 16:09 [PATCH v3 0/3] Basic DT support for Lenovo Miix 630 Jeffrey Hugo
2019-04-15 16:10 ` [PATCH v3 1/3] dt-bindings: input: add Elan 400 combo keyboard/touchpad over i2c Jeffrey Hugo
2019-04-18 9:35 ` Benjamin Tissoires
2019-04-26 22:49 ` Rob Herring [this message]
2019-04-29 15:15 ` Jeffrey Hugo
2019-04-15 16:11 ` [PATCH v3 2/3] HID: quirks: Fix keyboard + touchpad on Lenovo Miix 630 for DT Jeffrey Hugo
2019-04-18 9:34 ` Benjamin Tissoires
2019-04-18 9:51 ` Hans de Goede
2019-04-18 14:43 ` Jeffrey Hugo
2019-04-15 16:11 ` [PATCH v3 3/3] arm64: dts: qcom: Add Lenovo Miix 630 Jeffrey Hugo
2019-04-27 4:42 ` Bjorn Andersson
2019-04-29 15:16 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426224908.GA30389@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jikos@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).