From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin King Subject: [PATCH][next] Input: qt1050: fix less than zero comparison on an unsigned int Date: Tue, 7 May 2019 09:21:35 +0100 Message-ID: <20190507082135.21538-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov , Rob Herring , Marco Felsch , linux-input@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org From: Colin Ian King Currently the less than zero comparison of val is always false because val is an unsigned int. Fix this by making val a signed int. Addresses-Coverity: ("Unsigned compared against zero") Fixes: a33ff45923c8 ("Input: qt1050 - add Microchip AT42QT1050 support") Signed-off-by: Colin Ian King --- drivers/input/keyboard/qt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/qt1050.c b/drivers/input/keyboard/qt1050.c index 6b1603cb7515..4debddb13972 100644 --- a/drivers/input/keyboard/qt1050.c +++ b/drivers/input/keyboard/qt1050.c @@ -222,7 +222,7 @@ static struct regmap_config qt1050_regmap_config = { static bool qt1050_identify(struct qt1050_priv *ts) { - unsigned int val; + int val; /* Read Chip ID */ regmap_read(ts->regmap, QT1050_CHIP_ID, &val); -- 2.20.1