From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Aaron Ma <aaron.ma@canonical.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
benjamin.tissoires@redhat.com,
Christopher Heiny <Cheiny@synaptics.com>,
Andrew Duggan <aduggan@synaptics.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 2/2] Input: synaptics - remove X240 from the topbuttonpad list
Date: Mon, 20 May 2019 22:08:50 -0700 [thread overview]
Message-ID: <20190521050850.GC183429@dtor-ws> (raw)
In-Reply-To: <20190519072711.2592-2-aaron.ma@canonical.com>
Hi Aaron,
On Sun, May 19, 2019 at 03:27:11PM +0800, Aaron Ma wrote:
> Lenovo ThinkPad X240 does not have the top software button.
> When this wrong ID in top button list, smbus mode will fail to probe,
> so keep it working at PS2 mode.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> ---
> drivers/input/mouse/synaptics.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index b6da0c1267e3..6ae7bc92476b 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -140,7 +140,6 @@ static const char * const topbuttonpad_pnp_ids[] = {
> "LEN002E",
> "LEN0033", /* Helix */
> "LEN0034", /* T431s, L440, L540, T540, W540, X1 Carbon 2nd */
> - "LEN0035", /* X240 */
According to the history this came from Synaptics through Hans, so I'd
like to make sure there are no several X240 versions floating around...
> "LEN0036", /* T440 */
> "LEN0037", /* X1 Carbon 2nd */
> "LEN0038",
> --
> 2.17.1
>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-05-21 5:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-19 7:27 [PATCH 1/2] Input: elantech - enable middle button support on 2 ThinkPads Aaron Ma
2019-05-19 7:27 ` [PATCH 2/2] Input: synaptics - remove X240 from the topbuttonpad list Aaron Ma
2019-05-21 5:08 ` Dmitry Torokhov [this message]
2019-05-21 6:49 ` Benjamin Tissoires
2019-05-23 5:02 ` Aaron Ma
2019-05-21 5:10 ` [PATCH 1/2] Input: elantech - enable middle button support on 2 ThinkPads Dmitry Torokhov
2019-05-21 6:43 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521050850.GC183429@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=Cheiny@synaptics.com \
--cc=aaron.ma@canonical.com \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).