* [PATCH -next] Input: synaptics-rmi4 - Remove set but not used variable 'sensor_flags'
@ 2019-05-25 14:11 YueHaibing
2019-05-26 16:19 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-05-25 14:11 UTC (permalink / raw)
To: dmitry.torokhov, cheiny, nick; +Cc: linux-kernel, linux-input, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/input/rmi4/rmi_f12.c: In function rmi_f12_read_sensor_tuning:
drivers/input/rmi4/rmi_f12.c:76:6: warning: variable sensor_flags set but not used [-Wunused-but-set-variable]
It's not used since introduction in
commit b43d2c1e9353 ("Input: synaptics-rmi4 - add support for F12")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/input/rmi4/rmi_f12.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
index 5c7f48915779..72b5498e1a9f 100644
--- a/drivers/input/rmi4/rmi_f12.c
+++ b/drivers/input/rmi4/rmi_f12.c
@@ -73,7 +73,6 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
int pitch_y = 0;
int rx_receivers = 0;
int tx_receivers = 0;
- int sensor_flags = 0;
item = rmi_get_register_desc_item(&f12->control_reg_desc, 8);
if (!item) {
@@ -129,10 +128,8 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
offset += 2;
}
- if (rmi_register_desc_has_subpacket(item, 4)) {
- sensor_flags = buf[offset];
+ if (rmi_register_desc_has_subpacket(item, 4))
offset += 1;
- }
sensor->x_mm = (pitch_x * rx_receivers) >> 12;
sensor->y_mm = (pitch_y * tx_receivers) >> 12;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] Input: synaptics-rmi4 - Remove set but not used variable 'sensor_flags'
2019-05-25 14:11 [PATCH -next] Input: synaptics-rmi4 - Remove set but not used variable 'sensor_flags' YueHaibing
@ 2019-05-26 16:19 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2019-05-26 16:19 UTC (permalink / raw)
To: YueHaibing; +Cc: cheiny, nick, linux-kernel, linux-input
On Sat, May 25, 2019 at 10:11:19PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/input/rmi4/rmi_f12.c: In function rmi_f12_read_sensor_tuning:
> drivers/input/rmi4/rmi_f12.c:76:6: warning: variable sensor_flags set but not used [-Wunused-but-set-variable]
>
> It's not used since introduction in
> commit b43d2c1e9353 ("Input: synaptics-rmi4 - add support for F12")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thank you.
> ---
> drivers/input/rmi4/rmi_f12.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
> index 5c7f48915779..72b5498e1a9f 100644
> --- a/drivers/input/rmi4/rmi_f12.c
> +++ b/drivers/input/rmi4/rmi_f12.c
> @@ -73,7 +73,6 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
> int pitch_y = 0;
> int rx_receivers = 0;
> int tx_receivers = 0;
> - int sensor_flags = 0;
>
> item = rmi_get_register_desc_item(&f12->control_reg_desc, 8);
> if (!item) {
> @@ -129,10 +128,8 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
> offset += 2;
> }
>
> - if (rmi_register_desc_has_subpacket(item, 4)) {
> - sensor_flags = buf[offset];
> + if (rmi_register_desc_has_subpacket(item, 4))
> offset += 1;
> - }
>
> sensor->x_mm = (pitch_x * rx_receivers) >> 12;
> sensor->y_mm = (pitch_y * tx_receivers) >> 12;
> --
> 2.17.1
>
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-26 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-25 14:11 [PATCH -next] Input: synaptics-rmi4 - Remove set but not used variable 'sensor_flags' YueHaibing
2019-05-26 16:19 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).