* [PATCH] arm64: dts: allwinner: a64: Add lradc node
@ 2019-06-04 14:42 Luca Weiss
2019-06-04 14:59 ` Maxime Ripard
0 siblings, 1 reply; 3+ messages in thread
From: Luca Weiss @ 2019-06-04 14:42 UTC (permalink / raw)
Cc: Luca Weiss, Hans de Goede, Dmitry Torokhov, Rob Herring,
Mark Rutland, Maxime Ripard, Chen-Yu Tsai,
open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Allwinner sunXi SoC support, open list
Add a node describing the KEYADC on the A64.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
.../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 +
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
index 496125c6bfb7..507b737612ea 100644
--- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
+++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
@@ -5,6 +5,7 @@ Required properties:
- compatible: should be one of the following string:
"allwinner,sun4i-a10-lradc-keys"
"allwinner,sun8i-a83t-r-lradc"
+ "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc"
- reg: mmio address range of the chip
- interrupts: interrupt to which the chip is connected
- vref-supply: powersupply for the lradc reference voltage
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index 7734f70e1057..3a42352b5c9f 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -704,6 +704,14 @@
status = "disabled";
};
+ lradc: lradc@1c21800 {
+ compatible = "allwinner,sun50i-a64-lradc",
+ "allwinner,sun8i-a83t-r-lradc";
+ reg = <0x01c21800 0x400>;
+ interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ };
+
i2s0: i2s@1c22000 {
#sound-dai-cells = <0>;
compatible = "allwinner,sun50i-a64-i2s",
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node
2019-06-04 14:42 [PATCH] arm64: dts: allwinner: a64: Add lradc node Luca Weiss
@ 2019-06-04 14:59 ` Maxime Ripard
2019-06-04 15:07 ` Luca Weiss
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2019-06-04 14:59 UTC (permalink / raw)
To: Luca Weiss
Cc: Hans de Goede, Dmitry Torokhov, Rob Herring, Mark Rutland,
Chen-Yu Tsai,
open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Allwinner sunXi SoC support, open list
[-- Attachment #1: Type: text/plain, Size: 2046 bytes --]
Hi Luca,
On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote:
> Add a node describing the KEYADC on the A64.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
You should have a changelog detailing which changes you made to your
patch with the previous version, and why you made those changes (for
example because we looked at the a83t datasheet and found the two
controllers to be very similar).
> ---
> .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 +
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
> index 496125c6bfb7..507b737612ea 100644
> --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
> +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
> @@ -5,6 +5,7 @@ Required properties:
> - compatible: should be one of the following string:
> "allwinner,sun4i-a10-lradc-keys"
> "allwinner,sun8i-a83t-r-lradc"
> + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc"
> - reg: mmio address range of the chip
> - interrupts: interrupt to which the chip is connected
> - vref-supply: powersupply for the lradc reference voltage
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 7734f70e1057..3a42352b5c9f 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -704,6 +704,14 @@
> status = "disabled";
> };
>
> + lradc: lradc@1c21800 {
> + compatible = "allwinner,sun50i-a64-lradc",
> + "allwinner,sun8i-a83t-r-lradc";
> + reg = <0x01c21800 0x400>;
> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + };
> +
The bindings and the dt changes should be two different patches as
well.
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node
2019-06-04 14:59 ` Maxime Ripard
@ 2019-06-04 15:07 ` Luca Weiss
0 siblings, 0 replies; 3+ messages in thread
From: Luca Weiss @ 2019-06-04 15:07 UTC (permalink / raw)
To: Maxime Ripard
Cc: Hans de Goede, Dmitry Torokhov, Rob Herring, Mark Rutland,
Chen-Yu Tsai,
open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Allwinner sunXi SoC support, open list
[-- Attachment #1: Type: text/plain, Size: 2684 bytes --]
Hi Maxime,
sorry I forgot to mark it as a v2 and add the changelog to v1.
I've actually not split the patch into two on purpose as it's a pretty small
change and the patch adding support for the A83T didn't split out the device
tree changes - and recently in another patch of mine, the extra devicetree
patch was squashed into the driver patch by the maintainer while merging. I'll
fix this up asap.
Luca
On Dienstag, 4. Juni 2019 16:59:07 CEST Maxime Ripard wrote:
> Hi Luca,
>
> On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote:
> > Add a node describing the KEYADC on the A64.
> >
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
>
> You should have a changelog detailing which changes you made to your
> patch with the previous version, and why you made those changes (for
> example because we looked at the a83t datasheet and found the two
> controllers to be very similar).
>
> > ---
> >
> > .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 +
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++
> > 2 files changed, 9 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
> > b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt index
> > 496125c6bfb7..507b737612ea 100644
> > --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
> > +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
> >
> > @@ -5,6 +5,7 @@ Required properties:
> > - compatible: should be one of the following string:
> > "allwinner,sun4i-a10-lradc-keys"
> > "allwinner,sun8i-a83t-r-lradc"
> >
> > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-
lradc"
> >
> > - reg: mmio address range of the chip
> > - interrupts: interrupt to which the chip is connected
> > - vref-supply: powersupply for the lradc reference voltage
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index
> > 7734f70e1057..3a42352b5c9f 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -704,6 +704,14 @@
> >
> > status = "disabled";
> >
> > };
> >
> > + lradc: lradc@1c21800 {
> > + compatible = "allwinner,sun50i-a64-lradc",
> > + "allwinner,sun8i-a83t-r-
lradc";
> > + reg = <0x01c21800 0x400>;
> > + interrupts = <GIC_SPI 30
IRQ_TYPE_LEVEL_HIGH>;
> > + status = "disabled";
> > + };
> > +
>
> The bindings and the dt changes should be two different patches as
> well.
>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-04 15:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-04 14:42 [PATCH] arm64: dts: allwinner: a64: Add lradc node Luca Weiss
2019-06-04 14:59 ` Maxime Ripard
2019-06-04 15:07 ` Luca Weiss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).