From: Lee Jones <lee.jones@linaro.org>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: dmitry.torokhov@gmail.com, jikos@kernel.org,
benjamin.tissoires@redhat.com, bjorn.andersson@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com, agross@kernel.org,
david.brown@linaro.org, hdegoede@redhat.com,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] HID: quirks: Refactor ELAN 400 and 401 handling
Date: Thu, 6 Jun 2019 06:20:28 +0100 [thread overview]
Message-ID: <20190606052028.GY4797@dell> (raw)
In-Reply-To: <20190423160605.9970-1-jeffrey.l.hugo@gmail.com>
On Tue, 23 Apr 2019, Jeffrey Hugo wrote:
> There needs to be coordination between hid-quirks and the elan_i2c driver
> about which devices are handled by what drivers. Currently, both use
> whitelists, which results in valid devices being unhandled by default,
> when they should not be rejected by hid-quirks. This is quickly becoming
> an issue.
>
> Since elan_i2c has a maintained whitelist of what devices it will handle,
> use that to implement a blacklist in hid-quirks so that only the devices
> that need to be handled by elan_i2c get rejected by hid-quirks, and
> everything else is handled by default. The downside is the whitelist and
> blacklist need to be kept in sync.
>
> Suggested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> ---
> drivers/hid/hid-quirks.c | 64 ++++++++++++++++++++++++-----
> drivers/input/mouse/elan_i2c_core.c | 4 ++
> 2 files changed, 58 insertions(+), 10 deletions(-)
Reviewed-by: Lee Jones <lee.jones@linaro.org>
Tested-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-06-06 5:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 16:05 [PATCH v4 0/2] Basic DT support for Lenovo Miix 630 Jeffrey Hugo
2019-04-23 16:06 ` [PATCH v4 1/2] HID: quirks: Refactor ELAN 400 and 401 handling Jeffrey Hugo
2019-05-21 16:43 ` Bjorn Andersson
2019-06-05 23:25 ` Jeffrey Hugo
2019-06-06 7:06 ` Benjamin Tissoires
2019-06-06 14:30 ` Jeffrey Hugo
2019-06-06 5:20 ` Lee Jones [this message]
2019-04-23 16:06 ` [PATCH v4 2/2] arm64: dts: qcom: Add Lenovo Miix 630 Jeffrey Hugo
2019-06-06 5:50 ` Lee Jones
2019-06-06 7:26 ` Bjorn Andersson
2019-06-06 8:13 ` Lee Jones
2019-06-06 14:27 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606052028.GY4797@dell \
--to=lee.jones@linaro.org \
--cc=agross@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).