From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: =?utf-8?B?562U5aSNOiDnrZTlpI06IOetlA==?= =?utf-8?B?5aSNOiBbUEFUQ0g=?= =?utf-8?Q?=5D?= input: alps-fix the issue alps cs19 trackstick do not work. Date: Tue, 11 Jun 2019 09:23:33 +0200 Message-ID: <20190611072333.nd4va4q2m5epmukc@pali> References: <20190527100913.sgxrjrmphsjfmcdb@pali> <20190528071824.jimhixhtsynzwixe@pali> <20190610104310.qa5snt7jpcljodfv@pali> <5587ddb9-fb5f-03db-ac11-a696c85c5f2f@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <5587ddb9-fb5f-03db-ac11-a696c85c5f2f@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Hui Wang Cc: Xiaoxiao Liu , XiaoXiao Liu , "dmitry.torokhov@gmail.com" , "peter.hutterer@who-t.net" , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Xiaojian Cao , "zhangfp1@lenovo.com" , Naoki Saito , Hideo Kawase List-Id: linux-input@vger.kernel.org On Tuesday 11 June 2019 12:32:33 Hui Wang wrote: > On 2019/6/11 上午11:23, Hui Wang wrote: > > On 2019/6/11 上午11:05, Xiaoxiao Liu wrote: > > > Hi Pali, > > > > > > I discussed with our FW team about this problem. > > > We think the V8 method means a touchpad feature  and does not fit > > > the CS19 trackpoint device. > > > CS19 TrackPoint needn't  use any Absolute (Raw) mode and is usually > > > use standard mouse data. > > > CS19 TrackPoint device is a completely different device with > > > DualPoint device of Dell/HP. > > > CS19 TrackPoint device is independent  of Touchpad. (Touchpad is > > > connecting by I2C, TrackPoint is directly connecting with PS2 port.) > > > And it has completely another FW. > > > > > > So we think it is better to use the mouse mode for CS19 trackpoint. > > > > Maybe here is some mis-understanding,  the mouse mode here doesn't mean > > we use psmouse-base.c for cs19 (bare ps/2 mouse), we plan to use > > trackpoint.c to drive this HW, so this trackpoint has all features a > > trackpoint should have. > > > And I sent a patch one month ago to let the the trackpoint.c to drive this > HW: https://www.spinics.net/lists/linux-input/msg61341.html, maybe that > patch is reference. So instead of creating blacklist, you should check for TP_VARIANT_ALPS in alps.c and disallow its usage. Or maybe better, move trackpoint.c detect code before alsp.c detect code in psmouse-base. And no changes in alps.c are needed. > > Regards, > > > > Hui. > > > > > > > > Best Regards > > > Shona > > > -----邮件原件----- > > > 发件人: Pali Rohár > > > 发送时间: Monday, June 10, 2019 6:43 PM > > > 收件人: 劉 曉曉 Xiaoxiao Liu > > > 抄送: XiaoXiao Liu ; > > > dmitry.torokhov@gmail.com; peter.hutterer@who-t.net; > > > hui.wang@canonical.com; linux-input@vger.kernel.org; > > > linux-kernel@vger.kernel.org; 曹 曉建 Xiaojian Cao > > > ; zhangfp1@lenovo.com; 斉藤 直樹 Naoki > > > Saito ; 川瀬 英夫 Hideo Kawase > > > > > > 主题: Re: 答复: 答复: [PATCH] input: alps-fix the issue alps cs19 > > > trackstick do not work. > > > > > > On Monday 10 June 2019 10:03:51 Xiaoxiao Liu wrote: > > > > Hi Pali, > > > Hi! > > > > > > > We register our CS19 device as ALPS_ONLY_TRACKSTICK device. > > > > And let the V8 protocol function support the process of > > > > ALPS_ONLY_TRACKSTICK device. > > > > > > > > I want to confirm if this solution OK? > > > Yes, it is fine. Just make sure that touchapad input device is not > > > registered when this ALPS_ONLY_TRACKSTICK flag is set. So userspace > > > would not see any fake/unavailable touchpad input device. > > > > > > > Xiaoxiao.Liu > > > -- > > > Pali Rohár > > > pali.rohar@gmail.com -- Pali Rohár pali.rohar@gmail.com