From: Ting Shen <phoenixshen@chromium.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
Pi-Hsun Shih <pihsun@chromium.org>,
Enrico Granata <egranata@chromium.org>,
Ting Shen <phoenixshen@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Heiko Stuebner <heiko@sntech.de>,
Guenter Roeck <groeck@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Benson Leung <bleung@chromium.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
Colin Ian King <colin.king@canonical.com>
Subject: [PATCH] Input: cros_ec_keyb: mask out extra flags in event_type
Date: Fri, 14 Jun 2019 14:54:38 +0800 [thread overview]
Message-ID: <20190614065438.142867-1-phoenixshen@chromium.org> (raw)
http://crosreview.com/1341159 added a EC_MKBP_HAS_MORE_EVENTS flag to
the event_type field, the receiver side should mask out this extra bit when
processing the event.
Signed-off-by: Ting Shen <phoenixshen@chromium.org>
---
drivers/input/keyboard/cros_ec_keyb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
index d5600118159835..38cb6d82d8fe67 100644
--- a/drivers/input/keyboard/cros_ec_keyb.c
+++ b/drivers/input/keyboard/cros_ec_keyb.c
@@ -237,7 +237,7 @@ static int cros_ec_keyb_work(struct notifier_block *nb,
if (queued_during_suspend && !device_may_wakeup(ckdev->dev))
return NOTIFY_OK;
- switch (ckdev->ec->event_data.event_type) {
+ switch (ckdev->ec->event_data.event_type & EC_MKBP_EVENT_TYPE_MASK) {
case EC_MKBP_EVENT_KEY_MATRIX:
pm_wakeup_event(ckdev->dev, 0);
--
2.22.0.rc2.383.gf4fbbf30c2-goog
next reply other threads:[~2019-06-14 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 6:54 Ting Shen [this message]
2019-06-14 18:27 ` [PATCH] Input: cros_ec_keyb: mask out extra flags in event_type Enrico Granata
2019-06-14 18:55 ` Dmitry Torokhov
2019-06-14 19:09 ` Benson Leung
2019-06-14 19:19 ` Dmitry Torokhov
2019-06-14 19:32 ` Benson Leung
2019-06-18 8:43 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614065438.142867-1-phoenixshen@chromium.org \
--to=phoenixshen@chromium.org \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=colin.king@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=drinkcat@chromium.org \
--cc=egranata@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pihsun@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).