From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Parrot Subject: Re: [PATCH 1/2] Input: edt-ft5x06 - use get_unaligned_be16() Date: Fri, 28 Jun 2019 12:36:13 -0500 Message-ID: <20190628173613.bxtsvssuo5apsqdb@ti.com> References: <20190623063153.261546-1-dmitry.torokhov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20190623063153.261546-1-dmitry.torokhov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Andy Shevchenko , Marco Felsch , linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org Dmitry Torokhov wrote on Sat [2019-Jun-22 23:31:52 -0700]: > Instead of doing conversion by hand, let's use the proper accessors. > > Signed-off-by: Dmitry Torokhov > --- > drivers/input/touchscreen/edt-ft5x06.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c > index c639ebce914c..ec770226e119 100644 > --- a/drivers/input/touchscreen/edt-ft5x06.c > +++ b/drivers/input/touchscreen/edt-ft5x06.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > > #define WORK_REGISTER_THRESHOLD 0x00 > #define WORK_REGISTER_REPORT_RATE 0x08 > @@ -239,8 +240,8 @@ static irqreturn_t edt_ft5x06_ts_isr(int irq, void *dev_id) > if (tsdata->version == EDT_M06 && type == TOUCH_EVENT_DOWN) > continue; > > - x = ((buf[0] << 8) | buf[1]) & 0x0fff; > - y = ((buf[2] << 8) | buf[3]) & 0x0fff; > + x = get_unaligned_be16(buf) & 0x0fff; > + y = get_unaligned_be16(buf + 2) & 0x0fff; Appears to work fine in my test: Tested-by: Benoit Parrot > /* The FT5x26 send the y coordinate first */ > if (tsdata->version == EV_FT) > swap(x, y); > -- > 2.22.0.410.gd8fdbe21b5-goog >