From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] input: keyboard: gpio-keys-polled: use input name from pdata if available
Date: Sat, 6 Jul 2019 23:14:10 -0700 [thread overview]
Message-ID: <20190707061410.GA174189@dtor-ws> (raw)
In-Reply-To: <1561648031-15887-1-git-send-email-info@metux.net>
Hi Enrico,
On Thu, Jun 27, 2019 at 05:07:10PM +0200, Enrico Weigelt, metux IT consult wrote:
> Instead of hardcoding the input name to the driver name
> ('gpio-keys-polled'), allow the passing a name via platform data
> ('name' field was already present), but default to old behaviour
> in case of NULL.
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/input/keyboard/gpio_keys_polled.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c
> index 1eafe6b..c168493 100644
> --- a/drivers/input/keyboard/gpio_keys_polled.c
> +++ b/drivers/input/keyboard/gpio_keys_polled.c
> @@ -269,7 +269,7 @@ static int gpio_keys_polled_probe(struct platform_device *pdev)
>
> input = poll_dev->input;
>
> - input->name = pdev->name;
> + input->name = (pdata->name ? pdata->name : pdev->name);
> input->phys = DRV_NAME"/input0";
>
> input->id.bustype = BUS_HOST;
I also added fetching name from "label" device property ad applied,
thank you.
--
Dmitry
next prev parent reply other threads:[~2019-07-07 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 15:07 [PATCH 1/2] input: keyboard: gpio-keys-polled: use input name from pdata if available Enrico Weigelt, metux IT consult
2019-06-27 15:07 ` [PATCH 2/2] input: keyboard: gpio_keys_polled: use gpio lookup table Enrico Weigelt, metux IT consult
2019-07-07 6:14 ` Dmitry Torokhov [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-14 8:36 gpio-keys-polled enhancements v2 Enrico Weigelt, metux IT consult
2019-02-14 8:36 ` [PATCH 1/2] input: keyboard: gpio-keys-polled: use input name from pdata if available Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190707061410.GA174189@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=info@metux.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).