From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/5] Input: fsl-imx25-tcq: Use devm_platform_ioremap_resource() Date: Tue, 16 Jul 2019 09:30:44 +0200 Message-ID: <20190716073044.GA1182@penguin> References: <1554362243-2888-1-git-send-email-mojha@codeaurora.org> <1554362243-2888-2-git-send-email-mojha@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1554362243-2888-2-git-send-email-mojha@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mukesh Ojha Cc: s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, linux-imx@nxp.com, linux-input@vger.kernel.org, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-input@vger.kernel.org On Thu, Apr 04, 2019 at 12:47:19PM +0530, Mukesh Ojha wrote: > devm_platform_ioremap_resource() internally have platform_get_resource() > and devm_ioremap_resource() in it. So instead of calling them separately > use devm_platform_ioremap_resource() directly. > > Signed-off-by: Mukesh Ojha Applied, thank you. > --- > drivers/input/touchscreen/fsl-imx25-tcq.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/input/touchscreen/fsl-imx25-tcq.c b/drivers/input/touchscreen/fsl-imx25-tcq.c > index 1d6c8f4..b66df8a 100644 > --- a/drivers/input/touchscreen/fsl-imx25-tcq.c > +++ b/drivers/input/touchscreen/fsl-imx25-tcq.c > @@ -503,7 +503,6 @@ static int mx25_tcq_probe(struct platform_device *pdev) > struct input_dev *idev; > struct mx25_tcq_priv *priv; > struct mx25_tsadc *tsadc = dev_get_drvdata(dev->parent); > - struct resource *res; > void __iomem *mem; > int error; > > @@ -512,8 +511,7 @@ static int mx25_tcq_probe(struct platform_device *pdev) > return -ENOMEM; > priv->dev = dev; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - mem = devm_ioremap_resource(dev, res); > + mem = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(mem)) > return PTR_ERR(mem); > > -- > Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, > Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project > -- Dmitry