From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 4/5] Input: sun4i-ts: Use devm_platform_ioremap_resource() Date: Tue, 16 Jul 2019 09:34:25 +0200 Message-ID: <20190716073425.GC1182@penguin> References: <1554362243-2888-1-git-send-email-mojha@codeaurora.org> <1554362243-2888-5-git-send-email-mojha@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1554362243-2888-5-git-send-email-mojha@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Mukesh Ojha Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, linux-imx@nxp.com, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org On Thu, Apr 04, 2019 at 12:47:22PM +0530, Mukesh Ojha wrote: > devm_platform_ioremap_resource() internally have platform_get_resource() > and devm_ioremap_resource() in it. So instead of calling them separately > use devm_platform_ioremap_resource() directly. > > Signed-off-by: Mukesh Ojha Applied, thank you. > --- > drivers/input/touchscreen/sun4i-ts.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchscreen/sun4i-ts.c > index d2e14d9..bbb0104 100644 > --- a/drivers/input/touchscreen/sun4i-ts.c > +++ b/drivers/input/touchscreen/sun4i-ts.c > @@ -309,8 +309,7 @@ static int sun4i_ts_probe(struct platform_device *pdev) > input_set_drvdata(ts->input, ts); > } > > - ts->base = devm_ioremap_resource(dev, > - platform_get_resource(pdev, IORESOURCE_MEM, 0)); > + ts->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(ts->base)) > return PTR_ERR(ts->base); > > -- > Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, > Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project > -- Dmitry