From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v3 3/3] input: touchscreen mc13xxx: Add mc34708 support Date: Wed, 17 Jul 2019 06:36:55 +0300 Message-ID: <20190717033655.GC621@penguin> References: <20190716221929.3782-1-lukma@denx.de> <20190716221929.3782-4-lukma@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190716221929.3782-4-lukma@denx.de> Sender: linux-kernel-owner@vger.kernel.org To: Lukasz Majewski Cc: Lee Jones , linux-kernel@vger.kernel.org, Sascha Hauer , Enrico Weigelt , Thomas Gleixner , Kate Stewart , linux-input@vger.kernel.org List-Id: linux-input@vger.kernel.org On Wed, Jul 17, 2019 at 12:19:29AM +0200, Lukasz Majewski wrote: > From: Sascha Hauer > > The mc34708 has a different bit to enable pen detection. This > adds the driver data and devtype necessary to probe the device > and to distinguish between the mc13783 and the mc34708. > > Signed-off-by: Sascha Hauer > Signed-off-by: Lukasz Majewski > > --- > Changes for v3: > - Replace forward declaration of mc13xxx_driver_data with > structure definition > - Rename mc13xxx_driver_data with mc13xxx_chip > - Move static struct mc13xxx_chip mc13783_chip and mc34708_chip > closer to ID table > - Do not check mc13xxx device type You do not even need to define or store the type. Once it is dropped please feel free to add Acked-by: Dmitry Torokhov and merge with the other 2 patches. -- Dmitry