linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maximilian Luz <luzmaximilian@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Chen Yu <yu.c.chen@intel.com>, Darren Hart <dvhart@infradead.org>,
	Andy Shevchenko <andy@infradead.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Maximilian Luz <luzmaximilian@gmail.com>
Subject: [PATCH v3 0/2] Support for buttons on newer MS Surface devices
Date: Sat, 20 Jul 2019 17:05:09 +0200	[thread overview]
Message-ID: <20190720150511.95076-1-luzmaximilian@gmail.com> (raw)

This series adds support for power and volume buttons on 5th and 6th
generation Microsoft Surface devices. Specifically, it adds support for
the power-button on the Surface Laptop 1 and Laptop 2, as well as
support for power- and (on-device) volume-buttons on the Surface Pro 5
(2017), Pro 6, and Book 2.

These devices use the same MSHW0040 device as on the Surface Pro 4,
however, whereas the Pro 4 uses an ACPI notify handler, the newer
devices use GPIO interrupts to signal these events.

The first patch of this series ensures that the surfacepro3_button
driver, used for MSHW0040 on the Pro 4, does not probe for the newer
devices. The second patch adapts soc_button_array to implement the
actual button support.

Changes in v3:
  - [PATCH 1/2] platform/x86: surfacepro3_button: Fix device check
    - Changed subject line to fit conventions.
    - Added comments to clarify ACPI/DSM specific behavior.
    - Change return type of introduced device check function to bool.

  - [PATCH 1/2] Input: soc_button_array - Add support for newer
      surface devices
    - Changed subject line to fit conventions.
    - Explicitly require CONFIG_ACPI via Kconfig instead of guarding
      with #ifdef CONFIG_ACPI in code.
    - Add supported Surface devices to module description in Kconfig.
    - Allow -EPROBE_DEFER and other errors to be propagated from
      gpiod_get.
    - Fix deferral process in case GPIO subsystem is not initialized.

Changes in v2:
  - [PATCH 1/2] platform: Fix device check for surfacepro3_button
    No changes.

  - [PATCH 2/2] input: soc_button_array for newer surface devices
    Ensure the patch compiles without CONFIG_ACPI.

Maximilian Luz (2):
  platform/x86: surfacepro3_button: Fix device check
  Input: soc_button_array - Add support for newer surface devices

 drivers/input/misc/Kconfig                |   6 +-
 drivers/input/misc/soc_button_array.c     | 141 ++++++++++++++++++++--
 drivers/platform/x86/surfacepro3_button.c |  47 ++++++++
 3 files changed, 178 insertions(+), 16 deletions(-)

-- 
2.22.0

             reply	other threads:[~2019-07-20 15:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-20 15:05 Maximilian Luz [this message]
2019-07-20 15:05 ` [PATCH v3 1/2] platform/x86: surfacepro3_button: Fix device check Maximilian Luz
2019-07-25 17:57   ` Andy Shevchenko
2019-07-27  9:15     ` Dmitry Torokhov
2019-07-27 12:26       ` Andy Shevchenko
2019-07-28  9:57         ` Dmitry Torokhov
2019-07-26  1:48   ` Yu Chen
2019-07-20 15:05 ` [PATCH v3 2/2] Input: soc_button_array - Add support for newer surface devices Maximilian Luz
2019-07-22  8:00   ` Enrico Weigelt, metux IT consult
2019-07-23 11:29     ` Maximilian Luz
2019-07-27  9:14   ` Dmitry Torokhov
2019-07-27 12:01     ` Maximilian Luz
2019-07-28 10:01       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190720150511.95076-1-luzmaximilian@gmail.com \
    --to=luzmaximilian@gmail.com \
    --cc=andy@infradead.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).