From mboxrd@z Thu Jan 1 00:00:00 1970 From: stillcompiling@gmail.com Subject: [PATCH v3 3/3] HID: core: only warn once of oversize hid report Date: Mon, 22 Jul 2019 15:48:27 -0600 Message-ID: <20190722214827.29257-3-stillcompiling@gmail.com> References: <20190722163642.10417-2-stillcompiling@gmail.com> <20190722214827.29257-1-stillcompiling@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190722214827.29257-1-stillcompiling@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Joe Perches , Jiri Kosina , Benjamin Tissoires , "open list:HID CORE LAYER" , open list Cc: Joshua Clayton List-Id: linux-input@vger.kernel.org From: Joshua Clayton On HP spectre x360 convertible the message: hid-sensor-hub 001F:8087:0AC2.0002: hid_field_extract() called with n (192) > 32! (kworker/1:2) is continually printed many times per second, crowding out all else Protect dmesg by printing the warning only one time. Signed-off-by: Joshua Clayton --- drivers/hid/hid-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 210b81a56e1a..3eaee2c37931 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1311,8 +1311,8 @@ u32 hid_field_extract(const struct hid_device *hid, u8 *report, unsigned offset, unsigned n) { if (n > 32) { - hid_warn(hid, "hid_field_extract() called with n (%d) > 32! (%s)\n", - n, current->comm); + hid_warn_once(hid, "%s() called with n (%d) > 32! (%s)\n", + __func__, n, current->comm); n = 32; } -- 2.21.0