From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v3 1/2] platform/x86: surfacepro3_button: Fix device check Date: Sun, 28 Jul 2019 12:57:26 +0300 Message-ID: <20190728095726.GA775@penguin> References: <20190720150511.95076-1-luzmaximilian@gmail.com> <20190720150511.95076-2-luzmaximilian@gmail.com> <20190727091541.GD795@penguin> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: Maximilian Luz , Linux Kernel Mailing List , linux-input , Platform Driver , Hans de Goede , Chen Yu , Darren Hart , Andy Shevchenko , Benjamin Tissoires List-Id: linux-input@vger.kernel.org On Sat, Jul 27, 2019 at 03:26:41PM +0300, Andy Shevchenko wrote: > On Sat, Jul 27, 2019 at 12:15 PM Dmitry Torokhov > wrote: > > > > On Thu, Jul 25, 2019 at 08:57:53PM +0300, Andy Shevchenko wrote: > > > On Sat, Jul 20, 2019 at 6:05 PM Maximilian Luz wrote: > > > > > > > > Do not use the surfacepro3_button driver on newer Microsoft Surface > > > > models, only use it on the Surface Pro 3 and 4. Newer models (5th, 6th > > > > and possibly future generations) use the same device as the Surface Pro > > > > 4 to represent their volume and power buttons (MSHW0040), but their > > > > actual implementation is significantly different. This patch ensures > > > > that the surfacepro3_button driver is only used on the Pro 3 and 4 > > > > models, allowing a different driver to bind on other models. > > > > > > > > > > Acked-by: Andy Shevchenko > > > > > > assuming it will go thru Input subsystem. > > > > I can take it, but I do not think it is dependent on the other change > > and thus can go through platform tree as well. > > Pkease, take it. I do not expect any changes to the driver this cycle. OK, applied, thank you. -- Dmitry