From: Zhang Lixu <lixu.zhang@intel.com>
To: linux-input@vger.kernel.org, jikos@kernel.org,
benjamin.tissoires@redhat.com
Cc: srinivas.pandruvada@linux.intel.com,
linux-kernel@vger.kernel.org, lixu.zhang@intel.com
Subject: [PATCH v2 0/3] HID: intel-ish-hid: support s2idle and s3 in ish_suspend()
Date: Thu, 8 Aug 2019 18:21:10 +0800 [thread overview]
Message-ID: <20190808102113.27802-1-lixu.zhang@intel.com> (raw)
Currently, the NO_D3 flag is set in ish_probe(), the intel-ish-ipc driver
puts the ISH into D0i3 when system enter both suspend-to-idle(S0ix) and
suspend-to-mem(S3). These patches are to put the ISH into D3 when system
enter S3 and put the ISH into D0i3 when system enter S0ix.
I tested these patches on the following platforms:
ISH 5.2: ICL
ISH 5.0: CNL CFL WHL CML
ISH 4.0: GLK
ISH 3.0: KBL
Test steps:
* Run the IIO Sensor tool to read the accel_3d sensor data
* Run cmd "echo mem > /sys/power/state" to suspend-to-mem
* Press the keyboard to wake up OS.
* Check if the tool can get the sensor data after OS resume.
* Run cmd "echo freeze > /sys/power/state" to suspend-to-idle
* Press the keyboard to wake up OS.
* Check if the tool can get the sensor data after OS resume.
Test results:
The tool can get the accel_3d sensor data after resuming from both
suspend-to-mem and suspend-to-idle.
Changes from v1:
* Fix the indentation issue
* Elaborate the reason to remove the NO_D3 flag
* Split the PATCH v1 to three changes, and try to minimize the lines change
Zhang Lixu (3):
HID: intel-ish-hid: ipc: set NO_D3 flag only when needed
HID: intel-ish-hid: ipc: make ish suspend paths clear
HID: intel-ish-hid: ipc: check the NO_D3 flag to distinguish resume
paths
drivers/hid/intel-ish-hid/ipc/hw-ish.h | 1 +
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 95 +++++++++++++++----------
3 files changed, 61 insertions(+), 37 deletions(-)
--
2.17.1
next reply other threads:[~2019-08-08 10:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 10:21 Zhang Lixu [this message]
2019-08-08 10:21 ` [PATCH v2 1/3] HID: intel-ish-hid: ipc: set NO_D3 flag only when needed Zhang Lixu
2019-08-08 10:21 ` [PATCH v2 2/3] HID: intel-ish-hid: ipc: make ish suspend paths clear Zhang Lixu
2019-08-08 10:21 ` [PATCH v2 3/3] HID: intel-ish-hid: ipc: check the NO_D3 flag to distinguish resume paths Zhang Lixu
2019-08-19 2:52 ` [PATCH v2 0/3] HID: intel-ish-hid: support s2idle and s3 in ish_suspend() Srinivas Pandruvada
2019-08-19 12:06 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808102113.27802-1-lixu.zhang@intel.com \
--to=lixu.zhang@intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).